fix(whatsapp): add HTTPS proxy support for Baileys WebSocket (#43603) - #43822
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(whatsapp): add HTTPS proxy support for Baileys WebSocket (#43603)#43822kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Collaborator
austinpickett
approved these changes
Jun 11, 2026
austinpickett
left a comment
austinpickett
left a comment
Collaborator
There was a problem hiding this comment.
Approving as the canonical proxy implementation for this cluster (duplicates: #43607, #43659).
Why this PR wins:
- ✅
PROXY_AGENTnaming is consistent with the surrounding module-level ALL_CAPS constants (CHUNK_DELAY_MS,MAX_MESSAGE_LENGTH, etc.) - ✅ Proxy block is placed logically in the env-var parsing section (around line 57), not hoisted to the very top
- ✅ Comment references the tracking issue (#43603)
- ✅ No
package-lock.jsonchange — avoids a conflict with the pending Baileys rc13 bump in #43840
Minor nit (non-blocking): package-lock.json isn't included, but it can be regenerated with npm install after merge — not a blocker given the clean implementation.
Code looks correct: reads HTTPS_PROXY / https_proxy / HTTP_PROXY / http_proxy in priority order, constructs HttpsProxyAgent only when set, and passes it as agent: to makeWASocket. No behaviour change when the env var is unset. ✅
This was referenced Jun 11, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43603. Add https-proxy-agent dependency and pass an HttpsProxyAgent to Baileys makeWASocket when standard HTTPS_PROXY/HTTP_PROXY environment variables are set, allowing WhatsApp pairing to succeed behind HTTP(S) proxies.