fix: respect reasoning_config for custom providers and fix OpenRouter… - #43613
Closed
Stephen30Yan wants to merge 1 commit into
Closed
fix: respect reasoning_config for custom providers and fix OpenRouter…#43613Stephen30Yan wants to merge 1 commit into
Stephen30Yan wants to merge 1 commit into
Conversation
… hardcoded reasoning
Two bugs fixed in _build_kwargs():
1. OpenRouter path (line 418): hardcoded extra_body.reasoning to
{"enabled": True, "effort": "medium"} instead of reading the
user's reasoning_config. Now respects the toggle switch.
2. Custom/unknown providers: reasoning_config was completely ignored
because supports_reasoning was False for non-OpenRouter endpoints.
Now sends top-level reasoning_effort param (which most OpenAI-compat
APIs like DeepSeek/ARK expect). Maps "none" to "minimal" since
some APIs reject "none" as invalid.
Collaborator
Contributor
|
Thanks for identifying the reasoning-config forwarding gap. This is now implemented on
|
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… hardcoded reasoning
Two bugs fixed in _build_kwargs():
OpenRouter path (line 418): hardcoded extra_body.reasoning to {"enabled": True, "effort": "medium"} instead of reading the user's reasoning_config. Now respects the toggle switch.
Custom/unknown providers: reasoning_config was completely ignored because supports_reasoning was False for non-OpenRouter endpoints. Now sends top-level reasoning_effort param (which most OpenAI-compat APIs like DeepSeek/ARK expect). Maps "none" to "minimal" since some APIs reject "none" as invalid.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs