style(desktop): filled glyphs for in-thread tool icons - #43430
Merged
Conversation
Outline codicons read too thin at conversation-tool scale; a scoped filled modifier thickens tool-row and code-card icons without changing icon semantics elsewhere in the shell.
Contributor
🔎 Lint report:
|
alt-glitch
added
type/refactor
Replace the earlier text-stroke approach (which only bolds outline codicons — a font glyph has no fillable region) with dedicated solid SVG glyphs for tool rows. Adds ToolIcon, keyed by the same names as TOOL_META, with a codicon fallback for uncovered tools.
OutThisLife
changed the title
Sticky human bubbles park at --sticky-human-top (~4px), sliding under the titlebar's -webkit-app-region:drag strips. Electron resolves drag regions at the compositor level — z-index and pointer-events don't apply — so clicking a stuck bubble dragged the window instead of opening the edit composer. Add no-drag to the shared bubble base class (read-only bubble + edit composer). Covers the runtime side with a test: clicking a user bubble opens the inline edit composer through both the incremental external-store runtime and the stock one. (cherry picked from commit db4e1f4)
OutThisLife
enabled auto-merge
June 10, 2026 08:48
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…filled style(desktop): filled glyphs for in-thread tool icons
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…ol-codicons-filled style(desktop): filled glyphs for in-thread tool icons
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ol-codicons-filled style(desktop): filled glyphs for in-thread tool icons
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…ol-codicons-filled style(desktop): filled glyphs for in-thread tool icons
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…ol-codicons-filled style(desktop): filled glyphs for in-thread tool icons
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…ol-codicons-filled style(desktop): filled glyphs for in-thread tool icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filltricks only bold the outline. Confirmed visually that even a 1px stroke never reads as filledToolIcon(solid Phosphor "fill" SVG paths, MIT), keyed by the same names asTOOL_META, with a codicon fallback for any uncovered tool. Inlining path data mirrors the existingdirective-text.tsxprecedentRider: click-to-edit fix
db4e1f4f3from feat(agent): coding-context posture across CLI/TUI/desktop/ACP #43316 (preserves authorship): sticky user bubbles parked under the titlebar's-webkit-app-region: dragstrips, and Electron resolves drag regions at the compositor level (z-index / pointer-events don't apply), so clicking a stuck bubble dragged the window instead of opening the edit composer. The shared bubble base class now carves itself out withno-drag, with a runtime regression test.Test plan
npm run type-check(apps/desktop)vitest run tool-fallback-model.test.tsvitest run --environment jsdom user-message-edit.test.tsxterminal,read_file,search_files,web_search— leading glyphs should look solid/filled