Skip to content

fix(tools): exclude nested skill docs from strategy-3 flat search #43342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjakma wants to merge 1 commit into from
Closed

fix(tools): exclude nested skill docs from strategy-3 flat search #43342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tools/skills_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,8 +1049,22 @@ def _record(sd: Optional[Path], smd: Path) -> None:
_record(found_skill_md.parent, found_skill_md)

# Strategy 3: legacy flat <name>.md files anywhere under the dir.
# Exclude files nested inside another skill's directory (any ancestor
# between found_md and search_dir that contains its own SKILL.md).
# Those are reference/template assets, not standalone skills.
for found_md in search_dir.rglob(f"{name}.md"):
if found_md.name != "SKILL.md":
if found_md.name == "SKILL.md":
continue
in_other_skill = False
for p in found_md.parents:
if p == search_dir:
break
if search_dir not in p.parents:
break
if (p / "SKILL.md").exists():
in_other_skill = True
break
if not in_other_skill:
_record(None, found_md)

if len(candidates) > 1:
Expand Down