Skip to content

fix(providers): use hostname comparison for api.openai.com api_mode detection #43341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjakma wants to merge 1 commit into from
Closed

fix(providers): use hostname comparison for api.openai.com api_mode detection #43341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hermes_cli/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def determine_api_mode(provider: str, base_url: str = "") -> str:
return "anthropic_messages"
if url_lower.endswith("/anthropic") or "api.anthropic.com" in url_lower:
return "anthropic_messages"
if "api.openai.com" in url_lower:
if base_url_hostname(base_url) == "api.openai.com":

@teknium1 teknium1 Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a regression test through the known-provider path (get_provider(provider) is not None); the existing hostname tests use provider="" and only cover the adjacent unknown-provider branch.

return "codex_responses"
return TRANSPORT_TO_API_MODE.get(pdef.transport, "chat_completions")

Expand Down