Skip to content

Fix dashboard skills hub search reliability - #43337

Closed
shannonsands wants to merge 1 commit into
NousResearch:mainfrom
shannonsands:shannonsands/skills-hub-search-reliability
Closed

Fix dashboard skills hub search reliability#43337
shannonsands wants to merge 1 commit into
NousResearch:mainfrom
shannonsands:shannonsands/skills-hub-search-reliability

Conversation

@shannonsands

Copy link
Copy Markdown
Contributor

Summary

  • make dashboard Browse Hub searches timeout-safe with partial results instead of endless spinners
  • keep known hub/source chips visible even when probing or featured loading fails
  • add explicit frontend search/source error states and client-side abort timeout

Root Cause

  • hub searches used Future.result(timeout=...) in a way that could miss concurrent.futures.TimeoutError, then block during executor shutdown when a source worker stalled
  • source metadata probing could fail the whole dashboard source endpoint, hiding all hubs instead of surfacing degraded sources
  • the frontend had loading state but no durable error/timeout state for Browse Hub searches

Validation

  • source .venv/bin/activate && pytest tests/tools/test_skills_hub.py::TestParallelSearchSources tests/tools/test_skills_hub.py::TestUnifiedSearchDedup tests/hermes_cli/test_dashboard_admin_endpoints.py::TestSkillsHubSearchEndpoint tests/hermes_cli/test_dashboard_admin_endpoints.py::TestSkillsHubSourcesEndpoint -q
  • npm --workspace web exec eslint -- src/pages/SkillsPage.tsx src/lib/api.ts
  • npm run build --workspace web
  • browser smoke on http://127.0.0.1:9123/skills: Browse Hub renders source chips and returns ethereum results with per-source counts

@shannonsands
shannonsands marked this pull request as ready for review June 10, 2026 05:51
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard tool/skills Skills system (list, view, manage) labels Jun 10, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Fixed in #43326 instead

@teknium1 teknium1 closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants