Skip to content

fix(tests): update-command platform-gate tests spawn a real detached hermes update #43298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eazye19 wants to merge 1 commit into from
+15 −0
Closed

fix(tests): update-command platform-gate tests spawn a real detached hermes update #43298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/gateway/test_update_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,21 @@ class TestUpdateCommandPlatformGate:
interfaces (ACP, API server, webhooks) must be blocked.
"""

@pytest.fixture(autouse=True)
def block_real_update_spawn(self, tmp_path):
"""Stop a passing gate from spawning a REAL detached ``setsid hermes
update --gateway`` against this checkout. On detached-HEAD CI
checkouts (every pull_request run) that update switches the working
tree to origin/main and the restore step is skipped when detached,
poisoning every test process started afterwards.
"""
hermes_home = tmp_path / "hermes"
hermes_home.mkdir()
with patch("gateway.run._hermes_home", hermes_home), \
patch("shutil.which", side_effect=lambda x: f"/usr/bin/{x}"), \
patch("subprocess.Popen"):
yield

@pytest.mark.asyncio
async def test_blocks_programmatic_interface(self, monkeypatch):
"""``Platform.WEBHOOK`` is not a messaging platform and must be
Expand Down