fix(tools): truncate huge bookend messages in session_search (#43175) - #43267
Closed
kyssta-exe wants to merge 1 commit into
Closed
kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Contributor
Duplicate of #43184 — both fix #43175 by capping |
Contributor
Author
|
Closing as duplicate of #43184 — that PR is more comprehensive (filters compaction summaries AND caps content, with tests). Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43175. The session_search discovery mode returned bookend messages without any size limit, allowing 50K+ character compaction summaries to be reintroduced into fresh session prompts. Added _shape_bookend_message() that truncates bookend content at 4000 characters, preventing compression metadata from bloating new sessions.