fix(desktop): let explicit model switches escape broken config providers (#42241) - #42971
fix(desktop): let explicit model switches escape broken config providers (#42241)#42971rodboev wants to merge 4 commits into
Conversation
Verification ReviewReviewed: Clean fix for a real user-facing bug in the desktop model picker. Problem: When the default provider in config has no API key (or is broken), the desktop model picker's Fix: Routes active-session model changes through Test coverage: Two tests in No issues found. |
3704288 to
d08b209
Compare
e14ed93 to
d99ff31
Compare
95a47b3 to
ba1c9c7
Compare
|
Merged into During salvage I resolved one conflict — |
Summary
Hermes Desktop could get trapped on a default
config.yamlprovider that had no API key: new sessions failed immediately, and the in-session model picker still surfaced the same stale provider error even when the user explicitly picked a working model from a different provider. This PR makes the Desktop switch path honor the requested provider/model pair instead of re-failing on the broken config default.What Changed
--providerchoice instead of bootstrapping the broken default provider firstWhy It Matters
Desktop users need a GUI-only recovery path when a stale or hand-edited config points at a broken provider. The model picker should be that escape hatch, not another place where the old config lock is re-applied.
Verification
Upstream
Closes #42241.
Reported by @stephenlzc.