Scope Runs API by session key - #42459
Closed
necoweb3 wants to merge 1 commit into
Closed
Conversation
Contributor
|
LGTM. The run-scoping mirrors the session-scoping pattern from #42460 cleanly:
|
necoweb3
force-pushed
the
fix/runs-session-key-scope
branch
from
June 26, 2026 16:25
3c5dda2 to
484cb08
Compare
Contributor
Author
Rebased this PR onto current `origin/main` and reran the focused Runs API coverage.
Validation:
```text
python -m pytest tests/gateway/test_api_server_runs.py -q --timeout-method=thread
26 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stores the creating request's
X-Hermes-Session-Keyfor each/v1/runsrun and enforces that owner key on the run follow-up endpoints.Why
The API server allows multiple clients to share one
API_SERVER_KEYwhile usingX-Hermes-Session-Keyas the per-user/channel boundary.POST /v1/runsalready parses and forwards that key, but the follow-up endpoints only checked the bearer token andrun_id. A caller with the same API key and a different session key could read another run's status, attach to events, resolve approvals, or stop the run if it knew therun_id.Wrong-key requests now return 404 so the run's existence is not disclosed.
Changes
run_id -> X-Hermes-Session-Keyowner map for API runs.GET /v1/runs/{run_id}GET /v1/runs/{run_id}/eventsPOST /v1/runs/{run_id}/approvalPOST /v1/runs/{run_id}/stopTests