fix(nemo-relay): align adaptive config with tool_parallelism mode - #42331
Merged
kshitijk4poor merged 2 commits intoJun 8, 2026
Merged
Conversation
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…onfig-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…y-adaptive-config-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…y-adaptive-config-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…y-adaptive-config-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…y-adaptive-config-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…y-adaptive-config-shape fix(nemo-relay): align adaptive config with tool_parallelism mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Aligns the bundled
observability/nemo_relayplugin with the current NeMo Relay adaptive config shape.Before this change, Hermes adaptive examples and tests still used a legacy top-level adaptive
modefield. NeMo Relay's current adaptive config contract, including the 0.4 runtime line, nests that setting undertool_parallelism.mode.This change makes Hermes prefer
tool_parallelism.modewhen reading adaptive config, keeps the older top-levelmodeas a compatibility fallback, and updates the README/tests to use the current config shape.Execution control flow is unchanged. This PR aligns adaptive config parsing, docs, tests, and the default emitted mode metadata with the current NeMo Relay adaptive config vocabulary.
Related Issue
No GitHub issue filed.
Type of Change
Changes Made
plugins/observability/nemo_relay/__init__.pyto prefercomponents.config.tool_parallelism.mode, while preserving legacy top-levelcomponents.config.modeas a fallback.plugins/observability/nemo_relay/README.mdadaptive examples from top-levelmode = "route"to[components.config.tool_parallelism] mode = "observe_only".[components.config.tool_parallelism].tests/plugins/test_nemo_relay_plugin.pycoverage for the current nested config shape, unset-mode default, legacy fallback, and nested-over-legacy precedence.How to Test
Run the focused plugin test:
Run the broader plugin suite:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keys - N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows - N/AScreenshots / Logs