fix(transports/codex): clamp 'xhigh' reasoning effort to 'high' for xAI Grok - #42330
Closed
hex0x42424242 wants to merge 1 commit into
Closed
fix(transports/codex): clamp 'xhigh' reasoning effort to 'high' for xAI Grok#42330hex0x42424242 wants to merge 1 commit into
hex0x42424242 wants to merge 1 commit into
Conversation
…AI Grok The xAI Responses API for Grok supports 'low', 'medium', and 'high' reasoning effort levels, but lacks native support for 'xhigh'. When 'xhigh' effort is passed, it fails or reverts to default settings. This commit updates the Codex responses transport to clamp 'xhigh' to 'high' specifically when is_xai_responses is True.
alt-glitch
added
type/bug
Contributor
|
Thanks for the focused xAI compatibility fix. This is already implemented on current Automated hermes-sweeper review evidence:
|
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xAI Responses API for Grok supports 'low', 'medium', and 'high' reasoning effort levels, but lacks native support for 'xhigh'. When 'xhigh' effort is passed to Grok models that accept reasoning.effort, it fails or reverts to default settings. This PR updates the Codex responses transport to clamp 'xhigh' to 'high' specifically when is_xai_responses is True, preventing errors when calling Grok models with 'xhigh' effort. It also adds unit tests to verify the behavior under both xAI and generic Codex responses paths.