feat(simplify-code): risk-tiered application, Chesterton's Fence, slop + silent failure detection - #42209
Closed
Sahil-SS9 wants to merge 1 commit into
Closed
feat(simplify-code): risk-tiered application, Chesterton's Fence, slop + silent failure detection#42209Sahil-SS9 wants to merge 1 commit into
Sahil-SS9 wants to merge 1 commit into
Conversation
… slop + silent failure detection
Five targeted enhancements to the upstream simplify-code skill:
1. Risk-tiered application (SAFE/CAREFUL/RISKY) — safe changes auto-applied,
careful changes verified per-file, risky changes flagged for human review.
Prevents auto-applying N+1 restructures and public API renames.
2. Chesterton's Fence — before flagging anything for removal, reviewers run
'git blame' to understand why it exists. Low-confidence findings are
escalated rather than guessed.
3. AI slop detection — Quality reviewer now catches: extra comments restating
obvious code, unnecessary defensive null-checks on validated inputs, 'as any'
casts, and patterns inconsistent with the rest of the file.
4. Silent failure detection — Efficiency reviewer now catches: empty catch
blocks, ignored error returns, except:pass, .catch(()=>{}) with no handling,
and error propagation gaps.
5. Structured reviewer output with confidence+risk tags — reviewers report in
'file:line → problem → fix | confidence: H/M/L | risk: SAFE/CAREFUL/RISKY'
format, enabling the orchestrator to tier the application.
Plus 3 new pitfalls: over-trusting dead code tools, public contract awareness,
and preserving intentional error handling.
Total: +45/-8 lines. Keeps the 212-line compact spirit.
Ref: NousResearch#379
alt-glitch
added
type/feature
teknium1
added a commit
that referenced
this pull request
Jun 19, 2026
teknium1
added a commit
that referenced
this pull request
Jun 19, 2026
teknium1
added a commit
that referenced
this pull request
Jun 19, 2026
Collaborator
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five focused enhancements to the new simplify-code skill (#379, #41691).
1. Risk-tiered application (SAFE/CAREFUL/RISKY)
The current skill applies all findings flat. This adds three risk tiers:
2. Chesterton's Fence
Before flagging anything for removal, reviewers run
git blameto understand why it exists. Prevents the most common cleanup disaster.3. AI slop detection
Quality reviewer now catches: extra comments restating obvious code, unnecessary defensive null-checks on validated inputs,
as anycasts, patterns inconsistent with the file.4. Silent failure detection
Efficiency reviewer now catches: empty catch blocks, ignored error returns,
except: pass,.catch(() => {})with no handling, error propagation gaps.5. Structured reviewer output
Reviewers report in
file:line → problem → fix | confidence: H/M/L | risk: SAFE/CAREFUL/RISKYformat for tiered application.Plus 3 new pitfalls: over-trusting dead code tools, public contract awareness, preserving intentional error handling.
Diff: +45/-8 lines. Keeps the 212-line compact spirit.