fix(testing): accept pytest flags without explicit separator - #42204
Open
xushun007 wants to merge 2 commits into
Open
fix(testing): accept pytest flags without explicit separator#42204xushun007 wants to merge 2 commits into
xushun007 wants to merge 2 commits into
Conversation
…x fallback Add two new error-classification functions to agent/auxiliary_client.py: - _is_server_error(exc): catches HTTP 500-504 + gRPC UNAVAILABLE - _is_unavailable_error(exc): catches 503 + 'unavailable'/'overloaded' text Both are added to should_fallback and is_capacity_error in both sync (call_llm) and async (async_call_llm) paths, so 5xx proxy/gateway errors trigger provider fallback instead of failing through to the generic handler. Closes NousResearch#42088
1 task
Contributor
|
Thanks for addressing the test-runner ergonomics. Problems
Suggested changes
Automated hermes-sweeper review. |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42189
Summary
Teach the per-file test runner to accept pytest passthrough flags even when the caller omits the explicit
--separator.This preserves the documented
--behavior while also supporting the common shorthand: