fix(deps): align aiohttp extras pins with lazy Slack pin (3.13.4) - #42154
Merged
Conversation
The messaging/slack/homeassistant/sms extras exact-pinned aiohttp==3.13.3 while LAZY_DEPS['platform.slack'] already pins 3.13.4 (the CVE fix). On `hermes update` the extras pin won, downgrading aiohttp 3.13.4 -> 3.13.3 and reopening 10 published advisories (CVE-2026-34513/34515/34516/34517/ 34518/34519/34520/34525, -22815, -34514) until Slack's lazy refresh re-upgraded it. Bump all four extras to 3.13.4 to match the lazy pin, regenerate uv.lock, and add test_pyproject_aiohttp_pins_match_lazy_slack_pin to guard the alignment going forward. Fixes #31817
Contributor
🔎 Lint report:
|
Contributor
|
omg amazing ty |
alt-glitch
added
type/security
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes updateno longer downgrades aiohttp and reopens 10 published CVEs.The
messaging/slack/homeassistant/smsextras exact-pinnedaiohttp==3.13.3, whileLAZY_DEPS["platform.slack"]already pins3.13.4(the CVE fix from #26830). On update, the pyproject pin won and downgraded aiohttp3.13.4 → 3.13.3(the exact symptom reported in #31817), reopening 4 moderate + 6 low advisories until Slack's lazy refresh re-upgraded it on next use.Changes
pyproject.toml: bump aiohttp to3.13.4in the four extras that pin it (messaging,slack,homeassistant,sms); annotate with the CVE IDs.uv.lock: regenerated (uv lock) — aiohttp3.13.3 → 3.13.4, no other resolution drift.tests/test_project_metadata.py: addtest_pyproject_aiohttp_pins_match_lazy_slack_pin— fails if any pyproject aiohttp pin drifts from the lazy Slack pin again.Supply-chain posture
aiohttp 3.13.4published 2026-03-28 (~2.5 months old, well past the 2-week quarantine).==pin; matches our own lazy-deps pin (no chasing latest — 3.13.5 exists but adds no further fixes).Validation
messaging/slack/homeassistant/smsaiohttp pin3.13.33.13.4LAZY_DEPS["platform.slack"]uv lock --checktests/test_project_metadata.pyAdvisories closed: CVE-2026-34525, -34516, -34515, -22815 (moderate); -34514, -34517, -34520, -34518, -34513, -34519 (low).
Salvages #29538 by @cresslank (authorship preserved). Duplicate of #29743 by @m0n3r0 — credit to both. Closes #31817.
Infographic