fix(ollama): add nemotron-3-ultra to model selector - #42135
Open
htazq wants to merge 1 commit into
Open
Conversation
tonydwb
approved these changes
Jun 9, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Looks Good
- Adds
nemotron-3-ultrato Ollama cloud model selector, positioned after its sibling anchor models (nemotron-3-nano:30b,nemotron-3-super) in the merged list. - Includes dedicated test case
test_adds_curated_nemotron_ultra_when_registry_omits_it. - No security concerns, no debug artifacts.
Reviewed by Hermes Agent
teknium1
reviewed
Jul 14, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused selector fix. I found one current-main cache-path gap that needs resolution before this static fallback can provide the requested guarantee.
Problems
fetch_ollama_cloud_models()returns a fresh cache before the PR's merge point (hermes_cli/models.py:3732-3736) and returns stale cache on total discovery failure (hermes_cli/models.py:3775-3778). A cache created without this model will bypass the proposed insertion; the new test usesforce_refresh=Trueand does not cover either path.- The current Ollama Cloud contract says the catalog is dynamic with “no static list to maintain” (
tests/hermes_cli/test_ollama_cloud_provider.py:105-110). The PR should establish why this source-specific static exception is necessary.
Suggested changes
- Route cached and freshly discovered results through one idempotent curation step, with cache-path coverage, if a curated exception is intended.
- Document the verified upstream-source gap or update the discovery source instead of maintaining a local exception.
This is an automated hermes-sweeper review.
| if normalized and normalized not in seen: | ||
| seen.add(normalized) | ||
| merged.append(normalized) | ||
| if _OLLAMA_CLOUD_NEMOTRON_ULTRA not in seen: |
Contributor
There was a problem hiding this comment.
This insertion is skipped when fetch_ollama_cloud_models() returns its fresh disk cache or stale-cache fallback first (current main: hermes_cli/models.py:3732-3736, 3775-3778). Apply an idempotent post-processing step to every return path, and add cache coverage, if this fallback is meant to guarantee picker availability.
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Ollama model selector includes
nemotron-3-nano:30bandnemotron-3-super, but does not includenemotron-3-ultra.nemotron-3-ultracan already be used when it is configured as the current/custom model, so this appears to be a preset list omission rather than a provider/runtime issue.Expected behavior
nemotron-3-ultrashould be available in the Ollama default model selector, near the existing Nemotron entries.Actual behavior
The model selector does not show
nemotron-3-ultra, so users have to enter it manually as a custom model.Proposed change
Add
nemotron-3-ultrato the Ollama model preset list.Scope
This only updates the selector/model preset list. It does not change Ollama provider behavior, routing, authentication, or request formatting.
Tests
uv run --extra dev ruff check hermes_cli\models.py tests\hermes_cli\test_ollama_cloud_provider.pyuv run --extra dev python -m pytest -o addopts="" tests\hermes_cli\test_ollama_cloud_provider.pyNote: the repository pytest config uses
--timeout-method=signal, which raisesAttributeError: module 'signal' has no attribute 'SIGALRM'on Windows. The targeted pytest run overridesaddoptsfor the local Windows validation run.