fix: prioritize nested subparser dispatch over chat fallback - #4189
Closed
iborazzi wants to merge 7 commits into
Closed
fix: prioritize nested subparser dispatch over chat fallback#4189iborazzi wants to merge 7 commits into
iborazzi wants to merge 7 commits into
Conversation
feat(cli): add timestamps to session list
Refactor SlackAdapter methods for improved error handling and code clarity. Update connection logic to check both SLACK_BOT_TOKEN and SLACK_APP_TOKEN. Simplify message formatting and reaction handling.
|
This PR is extremely bloated and touches many different parts of the code base. |
alt-glitch
added
type/bug
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4184.
The issue was caused by checking for args.command is None before attempting to dispatch args.func. This prevented nested commands (like mcp add) from executing and instead forced the user into the chat REPL.
I've moved the args.func dispatch logic to the top of the main() function and added a return to ensure execution stops once a subcommand is successfully handled.