fix(agent): respect auxiliary.title_generation.timeout config for title generation - #41831
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(agent): respect auxiliary.title_generation.timeout config for title generation#41831liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
…le generation generate_title() defaulted to timeout=30.0, which caused call_llm() to use that hardcoded value instead of reading auxiliary.title_generation.timeout from config.yaml. Changed the default to None so call_llm's config-driven resolution kicks in (reads auxiliary.title_generation.timeout from config). Fixes NousResearch#41812
1 task
Contributor
|
Thanks for the focused report and regression tests. This is already resolved on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
generate_title()to respect theauxiliary.title_generation.timeoutconfig setting instead of always using a hardcoded 30-second timeout.Related Issue
Fixes #41812
Type of Change
Changes Made
agent/title_generator.py: Changedgenerate_title()defaulttimeoutfrom30.0toNone, socall_llm()readsauxiliary.title_generation.timeoutfrom config.yaml via its built-in_get_task_timeout()resolution.tests/agent/test_title_generator.py: Added 2 regression tests — one verifying the default timeout isNone(delegates to config), and one verifying an explicit timeout value is forwarded correctly.How to Test
auxiliary.title_generation.timeout: 300in config.yamlpytest tests/agent/test_title_generator.py -v— all 22 tests passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/agent/test_title_generator.py -vand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ACode Intelligence
agent/title_generator.py::generate_title(callers: 1 viaauto_title_session)agent/auxiliary_client.py::call_llm(timeout resolution:_get_task_timeout())call_llmconfig-driven timeout resolution (timeout=None→_get_task_timeout(task))