Skip to content

fix(agent): respect auxiliary.title_generation.timeout config for title generation - #41831

Closed
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/auxiliary-title-generation-timeout
Closed

fix(agent): respect auxiliary.title_generation.timeout config for title generation#41831
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:fix/auxiliary-title-generation-timeout

Conversation

@liuhao1024

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes generate_title() to respect the auxiliary.title_generation.timeout config setting instead of always using a hardcoded 30-second timeout.

Related Issue

Fixes #41812

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • agent/title_generator.py: Changed generate_title() default timeout from 30.0 to None, so call_llm() reads auxiliary.title_generation.timeout from config.yaml via its built-in _get_task_timeout() resolution.
  • tests/agent/test_title_generator.py: Added 2 regression tests — one verifying the default timeout is None (delegates to config), and one verifying an explicit timeout value is forwarded correctly.

How to Test

  1. Set auxiliary.title_generation.timeout: 300 in config.yaml
  2. Start a new session with a slow local model (e.g., Ollama)
  3. Title generation should now wait up to 300s instead of timing out at 30s
  4. Run pytest tests/agent/test_title_generator.py -v — all 22 tests pass

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/agent/test_title_generator.py -v and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Code Intelligence

  • Analyzed: agent/title_generator.py::generate_title (callers: 1 via auto_title_session)
  • Analyzed: agent/auxiliary_client.py::call_llm (timeout resolution: _get_task_timeout())
  • Blast radius: LOW — only affects title generation timeout, no control-flow changes
  • Related patterns: call_llm config-driven timeout resolution (timeout=None_get_task_timeout(task))

…le generation

generate_title() defaulted to timeout=30.0, which caused call_llm() to use
that hardcoded value instead of reading auxiliary.title_generation.timeout
from config.yaml. Changed the default to None so call_llm's config-driven
resolution kicks in (reads auxiliary.title_generation.timeout from config).

Fixes NousResearch#41812
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint labels Jun 8, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused report and regression tests. This is already resolved on current main; this is an automated hermes-sweeper review.

@teknium1 teknium1 closed this Jul 14, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression, auxillary title generation timeout ignores config.yaml settings

3 participants