feat(skills): sync popular web designs with awesome-design-md - #41675
feat(skills): sync popular web designs with awesome-design-md#41675lipebez wants to merge 1 commit into
Conversation
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Docs PR documenting upstream drift for popular-web-designs skill. Reference addition is well-structured and useful for maintainers. No code changes.
Reviewed by Hermes Agent
teknium1
left a comment
There was a problem hiding this comment.
Thanks for documenting the upstream relationship. The stated snapshot is supported: current main has 54 local templates, while the cited upstream commit has 73 design-md/*/DESIGN.md files.
Problems
skills/creative/popular-web-designs/SKILL.md:3changes the frontmatter description to 122 characters.AGENTS.md:888requires new or modernized skill descriptions to be one sentence of at most 60 characters. Current-main commit7d586ddb426fe2424960b972ff27e93e42a53aedspecifically reduced this same description to 60 characters.
Suggested changes
- Retain the detailed upstream-drift explanation in the body/reference, but use a ≤60-character frontmatter description and regenerate the derived website files.
Automated hermes-sweeper review.
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| name: popular-web-designs | |||
| description: 54 real design systems (Stripe, Linear, Vercel) as HTML/CSS. | |||
| version: 1.0.0 | |||
| description: Curated real design systems as HTML/CSS, sourced from VoltAgent/awesome-design-md and periodically compared with upstream. | |||
There was a problem hiding this comment.
This description is 122 characters, but AGENTS.md:888 requires every new or modernized skill description to be a single sentence of at most 60 characters. Commit 7d586ddb426fe2424960b972ff27e93e42a53aed specifically trimmed this skill to 60; please keep the upstream detail in the body/reference and shorten this frontmatter field.
|
Addressed the review in
Validation: |
|
Final scope cleanup in |
|
Scope update for the current head
@tonydwb, your earlier approval was explicitly for the documentation-only scope at I do not have repository permission to replace the existing |
d949ddb to
a2283f9
Compare
|
@teknium1 @tonydwb, this PR has now been fully refreshed on top of current The current head preserves the 20-template expansion (54 → 74 designs), corrects the imported typography guidance, retains the pinned upstream attribution/MIT notice, and passes the focused validation suite (37 tests), Ruff, Windows-footgun, generated-doc, source-parity, and font-URL checks. The approval on |
Summary
popular-web-designscatalog from 54 to 74 design systems by adding the 20 slugs missing from the pinned upstream snapshot.Upstream attribution
This contribution updates Hermes Agent's existing
popular-web-designsskill using design-system analyses fromVoltAgent/awesome-design-md, pinned at commit664b3e78fd1a298ba11973822da988483256d4b4.The upstream analyses are not claimed as original work by this contributor. This PR adapts them for Hermes by removing upstream YAML frontmatter, adding Hermes implementation guidance, open font substitutions, native-tool instructions, and validation coverage.
The original VoltAgent copyright and full MIT license notice are preserved in
references/ATTRIBUTION.md. Each newly imported template also identifies its upstream source directly.Scope and provenance
ShopifitoShopifyandSlacctoSlack.Validation
pytest tests/skills/test_popular_web_designs_skill.py(5 passed)pytest tests/website/test_generate_skill_docs.py(7 passed)pytest tests/website/test_extract_skills.py(15 passed)pytest tests/tools/test_skill_size_limits.py(10 passed)ruff check tests/skills/test_popular_web_designs_skill.pyruff format --check tests/skills/test_popular_web_designs_skill.pypython scripts/check-windows-footguns.py --diff origin/maingit diff --check origin/main...HEAD200 text/css; Dell 1996 intentionally uses system fonts only.origin/main; the generated catalog conflict was resolved by preserving current upstream content and changing only thepopular-web-designscount from 54 to 74.Review note
This PR was originally documentation-only. The earlier approval on commit
a7ac38c9c2c3ea42731422ea552d6a5795b7c348does not cover the expanded functional scope. A fresh review of the current feature head is required before merge.