Skip to content

feat(skills): sync popular web designs with awesome-design-md - #41675

Open
lipebez wants to merge 1 commit into
NousResearch:mainfrom
lipebez:docs/popular-web-designs-upstream-drift
Open

feat(skills): sync popular web designs with awesome-design-md#41675
lipebez wants to merge 1 commit into
NousResearch:mainfrom
lipebez:docs/popular-web-designs-upstream-drift

Conversation

@lipebez

@lipebez lipebez commented Jun 8, 2026

Copy link
Copy Markdown

Summary

  • Expands the bundled popular-web-designs catalog from 54 to 74 design systems by adding the 20 slugs missing from the pinned upstream snapshot.
  • Adapts the imported analyses for Hermes with implementation notes, open font substitutes, native-tool guidance, and responsive HTML/CSS usage instructions.
  • Preserves source-specific typography roles instead of applying a generic Primary + Mono pair; Dell 1996 intentionally retains its operating-system font stack.
  • Modernizes the skill to the current HARDLINE structure and adds invariant-based regression coverage.
  • Regenerates the corresponding website skill page and aggregate catalog entry.

Upstream attribution

This contribution updates Hermes Agent's existing popular-web-designs skill using design-system analyses from VoltAgent/awesome-design-md, pinned at commit 664b3e78fd1a298ba11973822da988483256d4b4.

The upstream analyses are not claimed as original work by this contributor. This PR adapts them for Hermes by removing upstream YAML frontmatter, adding Hermes implementation guidance, open font substitutions, native-tool instructions, and validation coverage.

The original VoltAgent copyright and full MIT license notice are preserved in references/ATTRIBUTION.md. Each newly imported template also identifies its upstream source directly.

Scope and provenance

  • Hermes template slugs: 74
  • Pinned upstream design slugs: 74
  • Upstream-only slugs: 0
  • Hermes-only slugs: 0
  • Newly imported templates: 20
  • Existing 54 templates remain Hermes adaptations of earlier snapshots; this PR does not claim they are byte-synchronized with the pinned upstream commit.
  • The 20 imported analysis bodies match the pinned upstream after frontmatter/H1 removal and two documented spelling corrections: Shopifi to Shopify and Slacc to Slack.
  • The expanded scope is 26 files with 7,146 additions and 203 deletions; it is content-heavy and does not modify runtime behavior.

Validation

  • pytest tests/skills/test_popular_web_designs_skill.py (5 passed)
  • pytest tests/website/test_generate_skill_docs.py (7 passed)
  • pytest tests/website/test_extract_skills.py (15 passed)
  • pytest tests/tools/test_skill_size_limits.py (10 passed)
  • Focused total: 37 passed
  • ruff check tests/skills/test_popular_web_designs_skill.py
  • ruff format --check tests/skills/test_popular_web_designs_skill.py
  • python scripts/check-windows-footguns.py --diff origin/main
  • git diff --check origin/main...HEAD
  • Documentation generator rerun: the PR's generated skill page and catalog entry remained byte-identical; unrelated generator drift was excluded.
  • 20/20 imported template bodies verified against upstream after the declared transformations.
  • 19 unique Google Fonts imports validated as 200 text/css; Dell 1996 intentionally uses system fonts only.
  • Local MIT notice verified as materially identical to the pinned upstream license.
  • The final commit is based directly on current origin/main; the generated catalog conflict was resolved by preserving current upstream content and changing only the popular-web-designs count from 54 to 74.

Review note

This PR was originally documentation-only. The earlier approval on commit a7ac38c9c2c3ea42731422ea552d6a5795b7c348 does not cover the expanded functional scope. A fresh review of the current feature head is required before merge.

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Docs PR documenting upstream drift for popular-web-designs skill. Reference addition is well-structured and useful for maintainers. No code changes.


Reviewed by Hermes Agent

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) labels Jun 8, 2026
@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 14, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the upstream relationship. The stated snapshot is supported: current main has 54 local templates, while the cited upstream commit has 73 design-md/*/DESIGN.md files.

Problems

  • skills/creative/popular-web-designs/SKILL.md:3 changes the frontmatter description to 122 characters. AGENTS.md:888 requires new or modernized skill descriptions to be one sentence of at most 60 characters. Current-main commit 7d586ddb426fe2424960b972ff27e93e42a53aed specifically reduced this same description to 60 characters.

Suggested changes

  • Retain the detailed upstream-drift explanation in the body/reference, but use a ≤60-character frontmatter description and regenerate the derived website files.

Automated hermes-sweeper review.

@@ -1,7 +1,7 @@
---
name: popular-web-designs
description: 54 real design systems (Stripe, Linear, Vercel) as HTML/CSS.
version: 1.0.0
description: Curated real design systems as HTML/CSS, sourced from VoltAgent/awesome-design-md and periodically compared with upstream.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is 122 characters, but AGENTS.md:888 requires every new or modernized skill description to be a single sentence of at most 60 characters. Commit 7d586ddb426fe2424960b972ff27e93e42a53aed specifically trimmed this skill to 60; please keep the upstream detail in the body/reference and shorten this frontmatter field.

@lipebez

lipebez commented Jul 19, 2026

Copy link
Copy Markdown
Author

Addressed the review in adfc872ba:

  • restored the skill frontmatter description to the current 60-character form;
  • kept the upstream-drift detail in the skill body and reference;
  • regenerated the corresponding website skill page with the current generator;
  • removed the now-unnecessary global catalog delta.

Validation: scripts/run_tests.sh tests/website/test_generate_skill_docs.py tests/website/test_extract_skills.py tests/tools/test_skill_size_limits.py — 34 passed, 0 failed. git diff --check is clean.

@lipebez

lipebez commented Jul 19, 2026

Copy link
Copy Markdown
Author

Final scope cleanup in 0337fb280: removed the remaining aggregate delta from website/docs/reference/skills-catalog.md. The PR now changes only the skill source, its upstream-comparison reference, and the corresponding generated skill page. Those three files are identical to the current-main validation tree that passed the 34-test docs/skills gate.

@lipebez lipebez changed the title docs(skills): document popular web designs upstream drift feat(skills): sync popular web designs with awesome-design-md Jul 20, 2026
@lipebez

lipebez commented Jul 20, 2026

Copy link
Copy Markdown
Author

Scope update for the current head d949ddb7ee236a41412c644b5ffb8b25a3736b14:

  • This PR is now a functional skill update, not documentation-only.
  • The 60-character frontmatter finding from @teknium1 is addressed, and the generated docs were refreshed.
  • Upstream attribution to VoltAgent/awesome-design-md and the full MIT notice are preserved; each of the 20 imported templates now identifies its source directly.
  • The current scope passes 38 targeted tests, Ruff, format, Windows-footgun, and diff checks.

@tonydwb, your earlier approval was explicitly for the documentation-only scope at a7ac38c9. Could you please perform a fresh review of the current head?

I do not have repository permission to replace the existing type/docs label. Maintainers: please relabel this PR as type/feature to match the expanded scope.

@lipebez
lipebez force-pushed the docs/popular-web-designs-upstream-drift branch from d949ddb to a2283f9 Compare August 1, 2026 23:00
@lipebez

lipebez commented Aug 1, 2026

Copy link
Copy Markdown
Author

@teknium1 @tonydwb, this PR has now been fully refreshed on top of current main as a single feature commit.

The current head preserves the 20-template expansion (54 → 74 designs), corrects the imported typography guidance, retains the pinned upstream attribution/MIT notice, and passes the focused validation suite (37 tests), Ruff, Windows-footgun, generated-doc, source-parity, and font-URL checks.

The approval on a7ac38c covered the earlier documentation-only scope, so I am explicitly requesting a fresh review of the current feature head. When convenient, could a maintainer also replace the stale type/docs label with type/feature? I do not have permission to change upstream labels directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users tool/skills Skills system (list, view, manage) type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants