Skip to content

feat(tool_progress): add full mode for untruncated tool arguments - #41617

Closed
WolframRavenwolf wants to merge 1 commit into
NousResearch:mainfrom
WolframRavenwolf:feat/tool-progress-full-mode
Closed

feat(tool_progress): add full mode for untruncated tool arguments#41617
WolframRavenwolf wants to merge 1 commit into
NousResearch:mainfrom
WolframRavenwolf:feat/tool-progress-full-mode

Conversation

@WolframRavenwolf

@WolframRavenwolf WolframRavenwolf commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a display.tool_progress: full mode that shows complete tool-call arguments in gateway progress notifications, while keeping thinking relay separate.

Changes

This branch was rebuilt from the current upstream/main and contains only the upstream-scoped changes for this feature.

Verification

  • python3 -m py_compile cli.py gateway/run.py hermes_cli/setup.py -> exit 0
  • uv run pytest tests/gateway/test_verbose_command.py -q -o addopts= -> exit 0

Notes

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery labels Jun 8, 2026
@WolframRavenwolf
WolframRavenwolf force-pushed the feat/tool-progress-full-mode branch 2 times, most recently from 1f95fff to f9987e9 Compare June 14, 2026 17:33
… chat

New 'full' mode for display.tool_progress — top of the mode hierarchy
(off → new → all → verbose → full):

- Shows complete tool arguments without any truncation in gateway chat
  (Telegram, Discord, etc.). Previously verbose mode capped at 200 chars.
- Added to /verbose cycle, hermes setup wizard, and mode validation.

This commit only affects tool call display. Assistant thinking relay
is handled separately by thinking_progress.

Files: run_agent.py, gateway/run.py, hermes_cli/setup.py
@WolframRavenwolf
WolframRavenwolf force-pushed the feat/tool-progress-full-mode branch from f9987e9 to e23a176 Compare June 14, 2026 17:37
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the PR. I reviewed this against current origin/main; the main behavior this adds is already implemented by the existing verbose tool-progress mode.

On current main, verbose already shows untruncated tool arguments by default when display.tool_preview_length is 0, and it preserves the existing terminal-command code-block formatting. Adding a separate full mode here would duplicate that behavior, diverge CLI/gateway/TUI mode cycles, and the new branch renders terminal commands less cleanly than the current verbose path.

Closing as redundant/stale. If we want a distinct future mode that ignores an explicitly configured positive preview limit, that should be designed fresh across CLI, gateway, TUI, docs, and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants