Normalize WSL and Git Bash media paths on Windows - #41596
Closed
IvanSolis1989 wants to merge 1 commit into
Closed
Conversation
Contributor
Code Review — Positive VerificationReviewed the full diff. The WSL/Git Bash path normalization is well-implemented:
The deduplication of path normalization logic across |
Contributor
|
Thanks for addressing the WSL/Git Bash media-path gap. The premise still holds on current main: explicit MEDIA extraction only expands the POSIX string at Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mnt/<drive>/...and Git Bash-style/<drive>/...media paths to native Windows drive paths before gateway attachment deliveryMEDIA:tags, bare local-file extraction, and validationTests
python -m py_compile gateway/platforms/base.py tests/gateway/test_platform_base.py tests/gateway/test_extract_local_files.pypython -m pytest -o addopts='' -p no:timeout tests/gateway/test_platform_base.py::TestExtractMedia tests/gateway/test_extract_local_files.py::TestBasicDetection -qpython -m ruff check gateway/platforms/base.py tests/gateway/test_platform_base.py tests/gateway/test_extract_local_files.pyNote: on this Windows runner I disabled the pytest-timeout plugin / project signal timeout addopts for the focused test command because
signal.SIGALRMis not available on Windows.