-
Notifications
You must be signed in to change notification settings - Fork 53.3k
feat(tui): RTL/Bidi support for Persian, Arabic, Hebrew, and Urdu text #41462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liuhao1024
wants to merge
1
commit into
NousResearch:main
Choose a base branch
from
liuhao1024:feat/tui-rtl-bidi-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,3 +364,29 @@ export const pick = <T>(a: T[]) => a[Math.floor(Math.random() * a.length)]! | |
|
|
||
| export const isPasteBackedText = (text: string) => | ||
| /\[\[paste:\d+(?:[^\n]*?)\]\]|\[paste #\d+ (?:attached|excerpt)(?:[^\n]*?)\]/.test(text) | ||
|
|
||
| /** | ||
| * First-strong-character RTL detection (matches CSS direction: auto behaviour). | ||
| * Returns true when the first non-whitespace code point falls in an RTL | ||
| * script range: Hebrew (0590–05FF), Arabic/Persian (0600–06FF), | ||
| * Arabic Supplement (0750–077F), Arabic Extended-A (08A0–08FF), | ||
| * Arabic Presentation Forms (FB50–FDFF, FE70–FEFF). | ||
| */ | ||
| export const isRtl = (text: string): boolean => { | ||
| if (!text) return false | ||
| const clean = stripAnsi(text) | ||
| for (let i = 0; i < clean.length; i++) { | ||
| const cp = clean.codePointAt(i)! | ||
| // Skip whitespace / control chars | ||
| if (cp <= 0x20 || (cp >= 0x09 && cp <= 0x0D)) continue | ||
| return ( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This returns for the first non-whitespace character, not the first strong directional character. |
||
| (cp >= 0x0590 && cp <= 0x05FF) || | ||
| (cp >= 0x0600 && cp <= 0x06FF) || | ||
| (cp >= 0x0750 && cp <= 0x077F) || | ||
| (cp >= 0x08A0 && cp <= 0x08FF) || | ||
| (cp >= 0xFB50 && cp <= 0xFDFF) || | ||
| (cp >= 0xFE70 && cp <= 0xFEFF) | ||
| ) | ||
| } | ||
| return false | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inner Box defaults to
flexDirection: 'row', soalignItemscontrols its vertical cross-axis rather than horizontal text placement. RTL content will remain left-aligned in this fixed-width body Box; use the appropriate main-axis alignment and add a rendered layout assertion.