fix: drain general httpx connection pool on Telegram send pool timeout - #41391
Closed
jackdaw-talks wants to merge 1 commit into
Closed
fix: drain general httpx connection pool on Telegram send pool timeout#41391jackdaw-talks wants to merge 1 commit into
jackdaw-talks wants to merge 1 commit into
Conversation
Add _drain_general_connections() to reset the general request pool (_request[1]) when pool timeout is detected during send/edit operations, mirroring the existing _drain_polling_connections() pattern for the polling pool (_request[0]). Previously only the polling pool was drained on reconnect, leaving send_message and edit_message permanently degraded when the general pool exhausted, requiring a full gateway restart to recover.
Contributor
|
✅ Verified — httpx connection pool exhaustion fix Reviewed the diff for Telegram send/edit path reliability under pool exhaustion.
The fix addresses a real production scenario: half-closed connections from proxy interruptions (e.g., sing-box) gradually exhausting the pool until all sends fail with |
This was referenced Jun 27, 2026
Contributor
|
Automated hermes-sweeper review: this older PR's fix is already implemented on current Evidence:
Thanks for the diagnosis and patch. The behavior this PR targeted is now covered on main, so closing this as implemented there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Telegram's httpx connection pool for general requests exhausts due to
stuck connections, only the polling pool is drained. This adds drain for send pool.
See commit for full details.