Skip to content

test(discord): align clarify/model-picker tests with fail-closed component auth #41338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teknium1 merged 1 commit into from
Jun 7, 2026
Merged

test(discord): align clarify/model-picker tests with fail-closed component auth #41338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/gateway/test_discord_clarify_buttons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ async def test_choice_falls_back_to_label_text_when_entry_missing(self):
view = ClarifyChoiceView(
choices=["alpha"],
clarify_id="cidGone",
allowed_user_ids=set(),
allowed_user_ids={"42"}, # matches _make_interaction's user; empty = fail-closed
)
interaction = _make_interaction()
# Doesn't raise; resolve_gateway_clarify returns False quietly
Expand Down Expand Up @@ -245,7 +245,7 @@ async def test_other_flips_entry_to_awaiting_text(self):
view = ClarifyChoiceView(
choices=["x", "y"],
clarify_id="cidD",
allowed_user_ids=set(),
allowed_user_ids={"42"}, # matches _make_interaction's user; empty = fail-closed
)

interaction = _make_interaction()
Expand Down
2 changes: 1 addition & 1 deletion tests/gateway/test_discord_model_picker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async def edit_original_response(**kwargs):
current_provider="copilot",
session_key="session-1",
on_model_selected=on_model_selected,
allowed_user_ids=set(),
allowed_user_ids={"123"}, # matches the interaction user; empty = fail-closed
)
view._selected_provider = "copilot"

Expand Down
Loading