refactor(gateway): migrate ALL remaining inline adapters (slack, dingtalk, whatsapp, matrix, feishu, telegram, wecom, email, sms) to plugins

[teknium1]

Summary

Migrates ALL remaining inline messaging-platform adapters — slack, dingtalk, whatsapp, matrix, feishu, telegram, wecom (+ wecom_callback), email, and sms — out of gateway/platforms/ into self-contained bundled plugins under plugins/platforms/<x>/, discovered via the platform registry instead of hardcoded Platform.<X> touchpoints. Completes the gateway-channel → plugin transition tracked in #41112 (companion to the registry architecture in #3823). With Discord, Home Assistant, Mattermost, Slack (#41160) and the born-as-plugin set already done, this removes the last hardcoded adapter branches from core.

Changes

Each platform follows the established Discord/HA migration shape:

• Adapter relocated via git mv (history preserved): gateway/platforms/<x>.py → plugins/platforms/<x>/adapter.py, plus __init__.py / plugin.yaml. Satellites travel with their adapter: telegram_network.py → telegram plugin; the three feishu_comment* / feishu_meeting_invite modules → feishu plugin; wecom_crypto.py + wecom_callback.py → wecom plugin (internal imports rewritten).
• register(ctx) exposes each platform with the hook set: standalone_sender_fn (out-of-process cron delivery), apply_yaml_config_fn (config.yaml → env/extra bridge), setup_fn (interactive wizard), is_connected, check_fn, plus allowed_users_env / allow_all_env / cron_deliver_env_var / max_message_length / emoji.
• Core touchpoints stripped: gateway/run.py factory branches (telegram's leading if, the rest elifs); gateway/config.py per-platform YAML→env blocks + _PLATFORM_CONNECTED_CHECKERS entries; hermes_cli/gateway.py static _PLATFORMS dicts + setup-map entries; hermes_cli/setup.py _setup_matrix; tools/send_message_tool.py _send_<x> dispatch (now a generic _registry_standalone_send registry hook). Telegram keeps _send_telegram (its plugin delegates to it); matrix keeps _send_matrix_via_adapter (native-media path) with its import repointed.

Deliberately left generic in core (same policy as prior migrations): the Platform.<X> enum literals, the _is_user_authorized allowlist maps, the cron delivery maps, and the bridged-loop shared-key handling.

Fixes uncovered during migration

• Explicit enabled: false honored for plugin platforms. The registry-driven plugin-enable pass re-enabled any plugin whose check_fn/is_connected passed, ignoring an explicit disable. Generalized the _enabled_explicit marker (was slack-only), made _enable_from_env read (not pop) it, and added an explicit-disable guard.
• get_connected_platforms() forces plugin discovery before the registry checker lookup so directly-constructed GatewayConfig resolves migrated checkers.
• Plugin is_connected reads via gateway.get_env_value (telegram/whatsapp/matrix) so setup-status and connected checks observe the same value; telegram/matrix gain explicit is_connected so they aren't enabled on mere SDK presence.
• hermes logs --component gateway now matches plugins.platforms.* adapter logs (added to COMPONENT_PREFIXES).
• Matrix stays hidden on Windows in the setup picker for the registry path too.

Validation

	Result
Targeted suites (dingtalk/matrix/feishu/telegram/whatsapp/config/send/setup/logs/connected-checkers)	passing
Full gateway + tools + cli + logging sweep	19001 passing; the only failures are 4 pre-existing local-only web-provider tests (ddgs installed locally, absent in CI — identical failures on clean main)
Live E2E (real plugin discovery → registry resolves all migrated adapters (5 + wecom/wecom_callback), legacy modules gone, factory branches stripped, env-enable, YAML bridges, standalone dispatch, setup discovery)	all 10 platforms register; 625 targeted + full hermetic suites green

Test imports swept across ~68 files (gateway.platforms.<x> → plugins.platforms.<x>.adapter); _setup_matrix/_setup_feishu tests retargeted to the plugins' interactive_setup; send-helper tests retargeted to the registry standalone_sender_fn.

Scope

Deliberately not migrated and left in core: webhook, api_server, msgraph_webhook (generic HTTP / change-notification ingress surfaces the #41112 tracker flags as not platform-shaped). signal, qqbot, weixin, yuanbao, bluebubbles are excluded because they have open contributor migration PRs (#41061, #41065, #41101, #40804, #31872) — preserving that work. Slack was folded in from #41160 (now closed) so this is the single PR for the whole transition.

Infographic

[github-actions]

🔎 Lint report: migrate/platforms-to-plugins vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 10036 on HEAD, 10002 on base (🆕 +34)

🆕 New issues (197):

Rule	Count
unresolved-attribute	88
unresolved-import	67
invalid-method-override	15
invalid-argument-type	11
invalid-assignment	7
unresolved-reference	3
call-non-callable	2
no-matching-overload	1
not-subscriptable	1
unused-type-ignore-comment	1
invalid-return-type	1

First entries

plugins/platforms/whatsapp/adapter.py:1100: [invalid-method-override] invalid-method-override: Invalid override of method `send_document`: Definition is incompatible with `BasePlatformAdapter.send_document`
plugins/platforms/dingtalk/adapter.py:1209: [unresolved-attribute] unresolved-attribute: Attribute `StreamingUpdateHeaders` is not defined on `None` in union `Unknown | None`
plugins/platforms/wecom/callback_adapter.py:134: [unresolved-attribute] unresolved-attribute: Attribute `AsyncClient` is not defined on `None` in union `Unknown | None`
plugins/platforms/telegram/adapter.py:1618: [unresolved-attribute] unresolved-attribute: Attribute `Document` is not defined on `None` in union `Unknown | None`
plugins/platforms/dingtalk/adapter.py:895: [invalid-assignment] invalid-assignment: Invalid subscript assignment with key of type `str | None` and value of type `str` on object of type `dict[str, str]`
plugins/platforms/dingtalk/adapter.py:1103: [unresolved-attribute] unresolved-attribute: Attribute `DeliverCardRequest` is not defined on `None` in union `Unknown | None`
plugins/platforms/dingtalk/adapter.py:1410: [unresolved-attribute] unresolved-attribute: Attribute `ChatbotHandler` is not defined on `None` in union `Unknown | None`
plugins/platforms/feishu/feishu_comment.py:41: [unresolved-import] unresolved-import: Cannot resolve imported module `lark_oapi.core.model.base_request`
plugins/platforms/matrix/adapter.py:714: [unresolved-import] unresolved-import: Cannot resolve imported module `mautrix.client.state_store`
plugins/platforms/email/adapter.py:374: [invalid-argument-type] invalid-argument-type: Argument to bound method `IMAP4.uid` is incorrect: Expected `str`, found `None`
plugins/platforms/wecom/adapter.py:284: [unresolved-attribute] unresolved-attribute: Attribute `ClientSession` is not defined on `None` in union `Unknown | None`
plugins/platforms/feishu/adapter.py:1368: [unresolved-import] unresolved-import: Cannot resolve imported module `lark_oapi.core`
plugins/platforms/feishu/adapter.py:3535: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_last_chunk_len` on type `MessageEvent`
plugins/platforms/telegram/adapter.py:2076: [unresolved-attribute] unresolved-attribute: Attribute `message_id` is not defined on `None` in union `None | Unknown`
tests/tools/test_send_message_tool.py:873: [invalid-assignment] invalid-assignment: Object of type `AsyncMock` is not assignable to attribute `standalone_sender_fn` on type `PlatformEntry | None`
plugins/platforms/telegram/adapter.py:4317: [unresolved-attribute] unresolved-attribute: Attribute `CHANNEL` is not defined on `None` in union `Unknown | None`
plugins/platforms/matrix/adapter.py:1288: [invalid-method-override] invalid-method-override: Invalid override of method `send_document`: Definition is incompatible with `BasePlatformAdapter.send_document`
plugins/platforms/telegram/adapter.py:3406: [unresolved-attribute] unresolved-attribute: Attribute `PRIVATE` is not defined on `None` in union `Unknown | None`
plugins/platforms/telegram/adapter.py:2937: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to `def group_providers(slugs) -> Unknown`
plugins/platforms/whatsapp/adapter.py:1089: [invalid-method-override] invalid-method-override: Invalid override of method `send_voice`: Definition is incompatible with `BasePlatformAdapter.send_voice`
plugins/platforms/matrix/adapter.py:2952: [unresolved-attribute] unresolved-attribute: Attribute `group` is not defined on `None` in union `Match[str] | None`
plugins/platforms/telegram/adapter.py:5295: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_last_chunk_len` on type `MessageEvent`
plugins/platforms/wecom/callback_adapter.py:25: [unresolved-import] unresolved-import: Cannot resolve imported module `defusedxml.ElementTree`
plugins/platforms/telegram/telegram_network.py:18: [unresolved-import] unresolved-import: Cannot resolve imported module `httpx`
plugins/platforms/dingtalk/adapter.py:1265: [unresolved-attribute] unresolved-attribute: Attribute `RobotRecallEmotionRequest` is not defined on `None` in union `Unknown | None`
... and 172 more

✅ Fixed issues (182):

Rule	Count
unresolved-attribute	85
unresolved-import	57
invalid-method-override	15
invalid-argument-type	10
invalid-assignment	7
call-non-callable	2
unresolved-reference	2
no-matching-overload	1
invalid-return-type	1
not-subscriptable	1
unused-type-ignore-comment	1

First entries

gateway/platforms/feishu.py:2595: [no-matching-overload] no-matching-overload: No overload of bound method `dict.get` matches arguments
gateway/platforms/dingtalk.py:1071: [unresolved-attribute] unresolved-attribute: Attribute `create_card_with_options_async` is not defined on `None` in union `Any | None`
gateway/platforms/dingtalk.py:1446: [unresolved-attribute] unresolved-attribute: Attribute `from_dict` is not defined on `None` in union `Unknown | None`
gateway/platforms/matrix.py:810: [unresolved-import] unresolved-import: Cannot resolve imported module `mautrix.util.async_db`
gateway/platforms/feishu.py:4577: [call-non-callable] call-non-callable: Object of type `None` is not callable
gateway/platforms/dingtalk.py:1067: [unresolved-attribute] unresolved-attribute: Attribute `CreateCardHeaders` is not defined on `None` in union `Unknown | None`
gateway/platforms/whatsapp.py:1078: [invalid-method-override] invalid-method-override: Invalid override of method `send_video`: Definition is incompatible with `BasePlatformAdapter.send_video`
gateway/platforms/whatsapp.py:1067: [invalid-method-override] invalid-method-override: Invalid override of method `send_image_file`: Definition is incompatible with `BasePlatformAdapter.send_image_file`
gateway/platforms/email.py:80: [invalid-assignment] invalid-assignment: Object of type `Literal["0"]` is not assignable to `Literal["0.16.0"]`
gateway/platforms/telegram.py:1519: [unresolved-attribute] unresolved-attribute: Attribute `builder` is not defined on `<special-form 'typing.Any'>` in union `Unknown | <special-form 'typing.Any'>`
gateway/platforms/wecom.py:1464: [invalid-method-override] invalid-method-override: Invalid override of method `send_voice`: Definition is incompatible with `BasePlatformAdapter.send_voice`
gateway/platforms/matrix.py:345: [unresolved-import] unresolved-import: Cannot resolve imported module `mautrix.types`
gateway/platforms/matrix.py:2809: [unresolved-import] unresolved-import: Cannot resolve imported module `markdown`
gateway/platforms/telegram.py:137: [unresolved-import] unresolved-import: Cannot resolve imported module `telegram.ext`
gateway/platforms/matrix.py:808: [unresolved-import] unresolved-import: Cannot resolve imported module `mautrix.crypto`
gateway/platforms/dingtalk.py:1276: [unresolved-attribute] unresolved-attribute: Attribute `RobotReplyEmotionRequest` is not defined on `None` in union `Unknown | None`
gateway/platforms/wecom.py:179: [unresolved-attribute] unresolved-attribute: Attribute `ClientWebSocketResponse` is not defined on `None` in union `Unknown | None`
gateway/platforms/dingtalk.py:78: [unresolved-import] unresolved-import: Cannot resolve imported module `alibabacloud_tea_util`
gateway/platforms/telegram.py:1618: [unresolved-attribute] unresolved-attribute: Attribute `Document` is not defined on `None` in union `Unknown | None`
hermes_cli/gateway.py:5177: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to `def qr_register(*, initial_domain: str = "feishu", timeout_seconds: int = 600) -> dict[Unknown, Unknown] | None`
gateway/platforms/dingtalk.py:257: [unresolved-attribute] unresolved-attribute: Attribute `AsyncClient` is not defined on `None` in union `Unknown | None`
hermes_cli/gateway.py:5249: [invalid-argument-type] invalid-argument-type: Argument to function `save_env_value` is incorrect: Expected `str`, found `Unknown | str | None`
gateway/platforms/dingtalk.py:1441: [unresolved-attribute] unresolved-attribute: Attribute `data` is not defined on `None` in union `Unknown | None`
gateway/platforms/telegram.py:2076: [unresolved-attribute] unresolved-attribute: Attribute `message_id` is not defined on `None` in union `None | Unknown`
gateway/platforms/feishu.py:1368: [unresolved-import] unresolved-import: Cannot resolve imported module `lark_oapi.core`
... and 157 more

Unchanged: 5008 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

[kshitijk4poor]

Reviewed this end-to-end (fetched into a worktree, ran the migrated-platform + shared-surface test suites serially, plus targeted repros). Solid, behavior-preserving migration overall — telegram's full YAML bridge is intact (all keys + the bare-off→"off" coercion), matrix's E2EE/device-id handling is untouched, and the feishu/wecom satellite modules all relocated with their cross-imports repointed. Test suite is green modulo known pre-existing flakes (matrix/telegram xdist ordering + the defusedxml-missing wecom_callback tests — all reproduce identically on clean main).

One blocker and a couple of smaller notes:

🔴 HIGH — explicit enabled: false is silently overridden for 6 of the migrated platforms when env credentials are present

The _enabled_explicit guard that prevents the registry enablement pass from re-enabling a platform the user explicitly disabled is wired into the slack block and the _enable_from_env helper (telegram/matrix), but the platforms with their own bespoke env-enablement blocks in _apply_env_overrides still flip enabled = True unconditionally on credential presence, without consulting the marker:

• email, sms, dingtalk, feishu, wecom, wecom_callback

Repro:

# config.yaml
dingtalk:
  enabled: false

DINGTALK_CLIENT_ID=... DINGTALK_CLIENT_SECRET=***   # in env

→ load_gateway_config() yields dingtalk.enabled == True. Same with sms + TWILIO_ACCOUNT_SID. The adapter starts against the user's explicit opt-out — the exact regression class this PR's gate work (#41112) is meant to close. The fix is mechanical: mirror the slack block's enabled_was_explicit = bool(extra.get("_enabled_explicit", False)) read before setting enabled = True in each of those six blocks.

🟡 MEDIUM — whatsapp is_connected changed from the prior lambda cfg: True

This looks intentional (the docstring cites #41112 — unconditional True made whatsapp always report "configured"), and it's arguably more correct, but it's a behavior change rather than a 1:1 relocation. Worth a line in the PR description so it's not read as a silent migration artifact.

🟢 LOW (cosmetic, non-blocking)

• _UPDATE_ALLOWED_PLATFORMS in gateway/run.py still lists the migrated platforms. These are now dead entries — the /update gate falls back to the registry (allow_update_command defaults True), so they can be dropped following the chore(gateway): drop plugin-migrated platforms from /update allowlist #32525 cleanup. Harmless if left.
• Stale module-path strings in docstrings/usage text: plugins/platforms/feishu/adapter.py:2466, plugins/platforms/feishu/feishu_comment_rules.py:360 (the python -m ... usage line), gateway/run.py:13470. Text-only; runtime imports are correct.

Coordination note

This touches gateway/run.py, gateway/config.py, tools/send_message_tool.py, and tests/gateway/test_platform_connected_checkers.py — the same shared surfaces as the in-flight yuanbao (#40804), signal (#41061), qqbot (#41065), and weixin (#41101) plugin-migration PRs. Whichever lands second will need a small rebase on those files (_create_adapter factory, the connected-checkers guard, the _UPDATE_ALLOWED_PLATFORMS frozenset).

[teknium1]

Merged via #49408 onto current main (commits 5600105 + c329279).

Your branch was ~1340 commits stale, so a plain cherry-pick would have reverted large swaths of unrelated work. The migration was re-applied surgically on current main with your authorship preserved per-commit (rebase merge): the 9 adapters + satellites relocated via git mv, each migration delta re-applied, and the core touchpoints re-stripped against the refactored gateway/run.py / gateway/config.py / hermes_cli/*.

Two things that had drifted since this PR opened were also fixed in the salvage:

• The matrix plugin's apply_yaml_config_fn gained the 4 keys main added to the inline block in the interim (allowed_users, ignore_user_patterns, process_notices, session_scope) — they would otherwise have been silently dropped.
• ~12 test files added on main since the base still imported gateway.platforms.* (incl. from … import X as Y and source-by-path reads) — swept and retargeted.

Verified end-to-end before merge: registry resolves all 10 platforms; _create_adapter check_fn gate, auth allowlist map, cron home-channel map, _UPDATE_ALLOWED_PLATFORMS, and max_message_length (slack 39000 / feishu 8000) all preserved; 7539 tests pass locally; CI green and CLEAN.