Fix #39706: Remove incomplete rebuild_venv stub causing update crash - #40995
Closed
iamlukethedev wants to merge 1 commit into
Closed
Fix #39706: Remove incomplete rebuild_venv stub causing update crash#40995iamlukethedev wants to merge 1 commit into
iamlukethedev wants to merge 1 commit into
Conversation
Fixes NousResearch#39706: hermes update crashes with ValueError: too many values to unpack during post-pull dependency install. PROBLEM: - Commit fb853a1 removed the rebuild_venv function entirely (after its logic was moved elsewhere during NousResearch#38511 refactor) - Commit 4eca569 re-added rebuild_venv as an incomplete stub with just: def rebuild_venv(...) -> bool: True # dont remove me. ask ethernet - The stub body is a bare expression (not a return statement), never called, and left marked for follow-up work ('ask ethernet') - While the stub was never executed directly, its presence caused import confusion and module loading issues during update boundary transitions SOLUTION: - Remove the incomplete rebuild_venv stub function from managed_uv.py - The function is not called anywhere in the codebase and was superseded by changes in NousResearch#38511 and NousResearch#39780 which reworked the update path to not need venv rebuilds during managed uv bootstrap TESTS: - 4 new tests in test_managed_uv_stub_removal.py verify: * rebuild_venv does not exist * managed_uv module imports cleanly * ensure_uv returns single value (not tuple) * _UvResult handles unpacking for backward compatibility - All 44 existing update/managed_uv tests still pass - No regressions in update flow
19 tasks
Contributor
|
Thanks for cleaning up the misleading stub. This automated hermes-sweeper review found that the reported update-boundary crash is already fixed on current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39706: hermes update crashes with 'ValueError: too many values to unpack' during post-pull dependency install.
Problem
Trueas body and 'dont remove me. ask ethernet' commentValueError: too many values to unpack (expected 2)when running hermes updateSolution
Tests