fix(gateway): recover Telegram polling after conflicts (#40691) - #40827
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(gateway): recover Telegram polling after conflicts (#40691)#40827Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Contributor
|
Automated hermes-sweeper review: this PR's target behavior has been superseded on current Evidence:
The specific |
This was referenced Aug 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #40691 by hardening Telegram polling conflict recovery so the gateway does not remain alive-but-wedged after a 409 conflict.
Changes:
drop_pending_updates=Trueto clear stale getUpdates state_verify_polling_after_reconnect()after successful conflict retry, matching the network-reconnect path so a wedged updater is detected and recoveredWhy
The issue reports that after conflict recovery the gateway logs "polling resumed" but stops processing both DMs and passive group routing until a full restart. The existing conflict retry could resume from stale pending updates and had no post-reconnect probe, so a dead consumer could sit silently while the process still reported healthy.
Verification
test_conflict_retry_drops_pending_updates_and_preserves_callbacktest_conflict_retry_schedules_heartbeat_probe_on_success/Users/evinova-self/.hermes/hermes-agent/venv/bin/python3 -m pytest tests/gateway/test_telegram_network_reconnect.py tests/gateway/test_telegram_conflict.py -v -o "addopts=" --tb=short0 1Competitor analysis
Open PR #40744 changes
drop_pending_updatesonly. It does not add the post-reconnect verification probe, has no focused regression tests, and includes an unrelatedtools/lazy_deps.pychange. This PR covers both reported recovery layers with focused tests and a smaller final diff.Auto-published by Moonsong via Path B automated pipeline.