fix(desktop): pass session profile through exportSession transcript reads - #40794
Closed
Dusk1e wants to merge 1 commit into
Closed
fix(desktop): pass session profile through exportSession transcript reads#40794Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
…eads Exporting a session from the cross-profile lists read its transcript without the owning profile, so the request fell through to the local primary. A remote (or non-default local) profile's rows live only on that profile's backend, so the export 404'd, came back empty, or returned the wrong transcript. exportSession now routes the transcript read to the session's owning profile, and both cross-profile callsites (command-center session list, sidebar actions menu) pass it through. Current-profile search export is unaffected. Restores the read-routing invariant from 9af54b2 (NousResearch#39894), which exportSession was the remaining sibling to miss.
Contributor
|
Thanks for the focused cross-profile export fix. This is already implemented on current Automated hermes-sweeper review evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Exporting a session from the cross-profile lists read its transcript without
the owning profile, so the request fell through to the local primary. A remote
(or non-default local) profile's rows live only on that profile's backend, so
the export 404'd, came back empty, or returned the wrong transcript.
exportSessionnow routes the transcript read to the session's owning profile(
params.profile ?? params.session?.profile ?? null). Both cross-profilecallsites — the command-center session list and the sidebar actions menu — pass
the profile through; current-profile search export is unaffected.
Reference
Parity follow-up to 9af54b2 (#39894, "make remote-profile sessions
first-class: resume, read, rename/archive/delete"), which established the
owner-profile read-routing invariant.
exportSessionwas the remaining siblingread path that still ignored it.
Tests
tsc -b(type-check): cleaneslint(changed files): cleansession-export.test.ts: 3/3 pass — owning-profile route · explicit-profile precedence · null (current-profile) fallback