Harden webhook payload parsing and gateway status topology - #40668
Open
c0nSpIc0uS7uRk3r wants to merge 1 commit into
Open
Harden webhook payload parsing and gateway status topology#40668c0nSpIc0uS7uRk3r wants to merge 1 commit into
c0nSpIc0uS7uRk3r wants to merge 1 commit into
Conversation
c0nSpIc0uS7uRk3r
force-pushed
the
honcho-kimi26-gateway-hardening
branch
from
June 19, 2026 16:52
ffc0eec to
7df2234
Compare
c0nSpIc0uS7uRk3r
marked this pull request as ready for review
June 19, 2026 16:53
Contributor
|
Thanks for the focused gateway hardening. The two reported current-main behaviors are verified: Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platformsentries when gateway runtime status transitions tostarting, so a fresh gateway boot does not report adapters from an old topology.Why
The webhook adapter currently attempts JSON parsing first, then falls back to form parsing on
JSONDecodeError. That is useful for genuine form payloads, but it also means malformed JSON bodies withContent-Type: application/jsoncan be reinterpreted instead of failing closed. For a webhook dispatch surface, JSON media types and JSON-looking bodies should reject malformed input before agent dispatch.Gateway runtime status also preserves old
platformsdata across a newstartingwrite. On a fresh boot, the adapter topology is redefined by the current run; stale platform entries from a previous gateway process can make status output claim adapters are present when the current gateway has not connected them.Tests
Run against current
origin/mainwith this PR commit only:Result: