Skip to content

test(cron): cover cron_list/status/tick/create CLI helpers - #40627

Closed
teknium1 wants to merge 1 commit into
mainfrom
salvage/40430-cron-cli-tests
Closed

test(cron): cover cron_list/status/tick/create CLI helpers#40627
teknium1 wants to merge 1 commit into
mainfrom
salvage/40430-cron-cli-tests

Conversation

@teknium1

@teknium1 teknium1 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds 5 cron CLI helper tests (cron_list/status/tick/create paths) not present on main. Test-only; supersedes stale #35814.

Validation

test_cron.py 9 passed (4 existing + 5 new).

Salvaged from #40430; re-verified on main, tightened, tested.

Co-authored-by: xuezhaolan <xuezhaolan@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: salvage/40430-cron-cli-tests vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9962 on HEAD, 9962 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5167 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have comp/cron Cron scheduler and job management comp/cli CLI entry point, hermes_cli/, setup wizard labels Jun 6, 2026
@teknium1

teknium1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Landed on main via #59510 (commit 3ba5ba8) — rebased onto current main from this branch, @xuezhaolan co-author credit preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants