feat(image-gen): add opt-in image_edit tool - #40498
Closed
BeliefanX wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 6, 2026
BeliefanX
force-pushed
the
feat/image-edit-tool-opt-in
branch
from
June 14, 2026 07:51
858c6e9 to
8be6baa
Compare
Contributor
Author
|
Closing this older standalone image_edit tool PR as obsolete: v0.17 upstream now supports image editing through the unified image_generate surface using image_url/reference_image_urls, so a separate opt-in image_edit tool is no longer needed. |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image_edittool under the existingimage_gentoolset.edit().images,reference_images, andreferences; duplicates are intentionally preserved.Relationship
image_edittool surface.mainso CI remains independent.image_editremains opt-in viaimage_gen/legacyimage_tools, not a core tool.Testing
venv/bin/python -m py_compile tools/image_edit_tool.py tests/tools/test_image_edit_tool.py acp_adapter/tools.py model_tools.py tests/acp/test_tools.py toolsets.pyvenv/bin/python -m pytest tests/tools/test_image_edit_tool.py tests/acp/test_tools.py -q -o 'addopts='— 84 passedvenv/bin/python -m pytest tests/tools/test_registry.py tests/test_model_tools.py -q -o 'addopts='— 56 passedvenv/bin/python -m ruff check tools/image_edit_tool.py tests/tools/test_image_edit_tool.py acp_adapter/tools.py tests/acp/test_tools.py model_tools.py toolsets.pygit diff --check