fix(dashboard): discover MCP tools on startup - #40407
Closed
kurom1ii wants to merge 3 commits into
Closed
Conversation
kurom1ii
force-pushed
the
fix/dashboard-mcp-discovery
branch
2 times, most recently
from
June 6, 2026 10:01
45a1a1a to
5da6e5e
Compare
The dashboard command (used by Hermes Desktop) did not call _prepare_agent_startup(), so MCP tools like github-mcp and codegraph were never discovered. Fix by calling start_background_mcp_discovery() from cmd_dashboard() before start_server(), matching the pattern in _prepare_agent_startup().
- Add atom + McpServerStatusItem type in session store - Wire session.info mcp_servers payload into - Add mcp.status RPC in tui_gateway/server.py - Display green dot next to connected MCP servers in settings - Show red 'disconnected' label for unreachable servers
kurom1ii
force-pushed
the
fix/dashboard-mcp-discovery
branch
from
June 6, 2026 15:35
5da6e5e to
8c029e4
Compare
This was referenced Jun 28, 2026
Contributor
|
Superseded by PR #44512 — #44512 implements the same fix this PR proposes: Thanks for the fix — closing as redundant. Credit to you and the other contributors who independently caught this (#42703, #43189, #40407 all targeted the same gap). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
hermes dashboardcommand (used by the Hermes Desktop Electron app as its backend process) starts the web UI server without discovering MCP tools. Unlike the CLI chat path which calls_prepare_agent_startup(), the dashboard'scmd_dashboard()function skips this entirely because"dashboard"is not in_AGENT_COMMANDS.This means MCP servers like
github-mcpandcodegraphare never connected when the dashboard starts, so the Desktop's AI agent sessions have no MCP tool access until the user manually clicks Reload MCP in Settings.Fix
Added
start_background_mcp_discovery()call fromcmd_dashboard()beforestart_server(), using the same background-thread pattern that_prepare_agent_startup()uses for the chat command. This keeps dashboard startup fast even if an MCP server is slow to respond.Testing
Before the fix: agent.log showed no MCP discovery during dashboard startup. After the fix:
MCP tools now appear in the dashboard/Desktop backend on startup without requiring manual Reload MCP.