Fix hidden directory filter broken on Windows - #401
Closed
ch3ronsa wants to merge 1 commit into
Closed
Conversation
Both _find_all_skills() and scan_skill_commands() used hardcoded
forward-slash strings ('/.git/', '/.hub/') to filter hidden dirs.
On Windows, str(Path(...)) returns backslash paths so the filter
never matched, exposing quarantined skills to users.
Replace string-based check with Path.parts membership test which
works on all platforms.
Contributor
Author
|
Didn't notice #390 already covers this with the same Path.parts fix and a full test suite. Closing as duplicate. |
zebadee2kk
added a commit
to zebadee2kk/hermes-agent
that referenced
this pull request
Jun 20, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 1, 2026
NousResearch#401) Exact owned-fork merge authorized by umbrella-auth-1533030101162266695 after semantic, security and immutable PASS plus 49 authoritative CI checks (44 success, 5 policy skips), exact head/base and clean mergeability readback. No NousResearch upstream mutation.
This was referenced Aug 16, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 16, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 16, 2026
This was referenced Aug 16, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 17, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 17, 2026
cermm
added a commit
to cermm/hermes-agent
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389
Summary
_find_all_skills()intools/skills_tool.pyandscan_skill_commands()inagent/skill_commands.pyused hardcoded forward-slash strings ('/.git/','/.hub/') to filter hidden directoriesstr(Path(...))returns backslash-separated paths, so the filter never matchedFix
Replaced string-based path check with
Path.partsmembership test, which is platform-independent:Test plan
C:\Users\me\.hermes\skills\.hub\quarantine\...) — correctly blocked/home/me/.hermes/skills/.hub/...) — correctly blocked