fix(gateway): honor Discord connect timeout for ready wait - #40070
Closed
konsisumer wants to merge 1 commit into
Closed
konsisumer wants to merge 1 commit into
konsisumer wants to merge 1 commit into
Conversation
1 task
Contributor
Author
|
Rebased onto |
konsisumer
force-pushed
the
fix/discord-ready-timeout
branch
from
June 11, 2026 22:40
434a819 to
59a1578
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Per the reporter's clarification on 2026-06-01, the outer gateway platform timeout can be raised to 90s, but DiscordAdapter.connect() still times out internally after 30s while waiting for Discord readiness. This change makes the Discord ready wait use HERMES_GATEWAY_PLATFORM_CONNECT_TIMEOUT too, including the existing non-positive value behavior for disabling the timeout.
Addressing maintainer feedback
A maintainer linked #16713 and #16739 as the same slash-command-sync startup-budget root cause. This follow-up keeps that context intact and fixes the remaining adapter-level 30s wait that still fires after the outer timeout path is extended.
How to test
The full repository command failed during collection in this sandbox because fastapi is not installed: ModuleNotFoundError: No module named 'fastapi'.
What platforms tested on
Refs #19776