fix(background_review): add read_file to review fork tool whitelist - #40060
Open
HeLLGURD wants to merge 1 commit into
Open
fix(background_review): add read_file to review fork tool whitelist#40060HeLLGURD wants to merge 1 commit into
HeLLGURD wants to merge 1 commit into
Conversation
The background review fork could not read external files needed for skill authoring. The model either fabricated content or called the non-existent skill_manage(action='read_file') and hit a hard deny-wall. read_file is read-only (size-guarded, device-path checked) - adding it to the whitelist closes the gap without introducing write risk. Supersedes stale PR NousResearch#27422. Fixes NousResearch#40003.
Contributor
|
Thanks for identifying the current deny-wall: Problems
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The background review fork ran with a tool whitelist of memory + skills toolsets only. When authoring or patching a skill that references an existing file, the fork had no way to read that file:
ead_file action - calling it returned Unknown action 'read_file'
ead_file (file toolset) was denied by the whitelist
The model either fabricated content or guessed skill_manage(action='read_file') and hit the deny-wall.
Fix
Add
ead_file to
eview_whitelist after it is built from the toolset definitions.
ead_file is read-only (size-guarded, device-path checked) - no write risk. Also update the review prompt to mention it. Supersedes stale PR #27422 which targeted the since-refactored
un_agent.py path.
Fixes #40003