Fix webhook platform registration and onboarding delivery - #4000
Fix webhook platform registration and onboarding delivery#4000orangebread wants to merge 1 commit into
Conversation
|
Validated from a real VPS deployment using Hermes webhook + Telegram together. What I can confirm from production use:
Why this matters in practice: On this VPS, webhook is used as a real event ingress path and Telegram is the real user-facing delivery channel. Without the webhook platform registration, webhook-triggered runs are not treated as a first-class platform correctly. And without suppressing the home-channel onboarding for webhook-origin sessions, the delivery path can send misleading onboarding noise instead of the actual user-facing result. So the fixes in this PR match a real production need, not just a theoretical cleanup. From checking current upstream locally before commenting:
That means this PR is still addressing a real gap in current main. Thanks — this is the right direction. |
|
@alexx-ftw Hi Alexx, what are next steps for this PR? Should I be addressing anything or is this something you/your team will handle internally? Thanks! |
|
Hello! We did a hot fix internally but it breaks at every /update naturally so we are just waiting on this the get approved/merged. Thanks for the effort |
|
Thanks for the contribution, @orangebread! The fixes in this PR have already landed on Automated hermes-sweeper review — closing as implemented on main.
All of this shipped on 2026-04-02 via commit |
Summary
Validation
pytest -q -o addopts='' tests/hermes_cli/test_tools_config.py -k 'webhook_default_when_platform_not_configured or gateway_toolset_includes_all_messaging_platforms or skills_config_covers_tools_config_platforms' tests/gateway/test_webhook_home_channel_prompt.py