docs(contributing): document local checks matching CI gates - #39991
Closed
lac1203 wants to merge 1 commit into
Closed
docs(contributing): document local checks matching CI gates#39991lac1203 wants to merge 1 commit into
lac1203 wants to merge 1 commit into
Conversation
External contributors regularly hit surprise CI failures on the two blocking required checks that weren't reflected in the pre-PR guidance: `ruff enforcement (blocking)` (PLW1514 unspecified-encoding) and `Windows footguns (blocking)`. The "Before submitting" section only mentioned running tests, so first-time PRs failed on lint/footgun gates that are trivial to catch locally. Add a copy-pasteable block to CONTRIBUTING.md "Before submitting" listing the three commands that match CI's blocking gates — all ship with the `[dev]` install, so no extra setup is needed — and align the PR template's Code checklist to reference the same checks. Docs-only; both documented commands verified passing on a clean tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
Contributor
|
Thanks for improving the contributor pre-submit guidance. The gap is real: current Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Claude reported validating the documented commands against the repo workflows; no code, secrets, deploys, or merges.