fix(desktop): IME composition prevents send button from switching to arrow - #39918
Closed
chenyf1010 wants to merge 1 commit into
Closed
fix(desktop): IME composition prevents send button from switching to arrow#39918chenyf1010 wants to merge 1 commit into
chenyf1010 wants to merge 1 commit into
Conversation
…arrow After CJK IME composition ends, the composer state was not synced with the DOM content, causing the send button to remain as the voice/microphone icon instead of switching to the up-arrow. The onCompositionEnd handler now defers the state sync via setTimeout(0) to avoid React 18 automatic batching swallowing the state update, ensuring the send-button icon updates immediately after IME input.
Contributor
|
Thanks for the IME-focused report and proposed fix. This is an automated hermes-sweeper review; the requested behavior is already implemented on current
Closing as implemented on main. |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CJK IME composition causing the send button to stay as microphone icon instead of switching to the up-arrow after Chinese/Japanese/Korean input.
Root Cause
The
onCompositionEndhandler only setcomposingRef.current = falsewithout syncing the composer state with the final DOM content. As a result,draftstays empty,hasComposerPayloadremains false, and the button stays as voice/microphone icon.Fix
Added state sync logic in
onCompositionEndthat reads the final committed text from the editor DOM and pushes it toaui.composer().setText(). The sync is wrapped insetTimeout(0)to avoid React 18 automatic batching swallowing the state update.Test Plan