Skip to content

feat: add Fireworks context length detection support - #3989

Closed
sroecker wants to merge 1 commit into
NousResearch:mainfrom
sroecker:feat/add-fireworks-context-detection
Closed

feat: add Fireworks context length detection support#3989
sroecker wants to merge 1 commit into
NousResearch:mainfrom
sroecker:feat/add-fireworks-context-detection

Conversation

@sroecker

Copy link
Copy Markdown
Contributor

Summary

Adds automatic context length detection for Fireworks-hosted models.

Changes

  • Add "api.fireworks.ai" URL mapping to "_URL_TO_PROVIDER" for automatic provider detection from base URL
  • Add "fireworks" to "PROVIDER_TO_MODELS_DEV" mapping for models.dev registry lookup

Problem Solved

Previously, models served via Fireworks (e.g., "accounts/fireworks/routers/kimi-k2p5-turbo") would default to 128K context because:

  1. Fireworks URL wasn't in the provider mapping
  2. Fireworks wasn't mapped for models.dev registry lookup

Result

Fireworks models now get their correct context length from the models.dev registry instead of falling back to the 128K default.

Test Plan

  • Verify context length detection works for Fireworks-hosted models
  • Confirm no regressions for other providers

- Add Fireworks URL mapping to _URL_TO_PROVIDER for automatic provider detection
- Add Fireworks to PROVIDER_TO_MODELS_DEV for models.dev registry lookup
- Enables automatic context length resolution for Fireworks-hosted models
  (e.g., accounts/fireworks/routers/kimi-k2p5-turbo)

Closes context length fallback to 128K for Fireworks models
teknium1 pushed a commit that referenced this pull request Mar 31, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
Cherry-picked from PR #3989 with models.dev key fix.
teknium1 added a commit that referenced this pull request Mar 31, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)


Cherry-picked from PR #3989 with models.dev key fix.

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #4158 with a fix: the models.dev provider key is fireworks-ai, not fireworks. Your original mapping would have silently failed the lookup. Cherry-picked with authorship preserved. Thanks for the contribution!

@teknium1 teknium1 closed this Mar 31, 2026
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)


Cherry-picked from PR NousResearch#3989 with models.dev key fix.

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 28, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
Cherry-picked from PR NousResearch#3989 with models.dev key fix.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)


Cherry-picked from PR NousResearch#3989 with models.dev key fix.

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)


Cherry-picked from PR NousResearch#3989 with models.dev key fix.

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)


Cherry-picked from PR NousResearch#3989 with models.dev key fix.

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
nepenth pushed a commit to nepenth/hermes-agent that referenced this pull request Aug 7, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
Cherry-picked from PR NousResearch#3989 with models.dev key fix.
jh1nresh pushed a commit to jh1nresh/hermes-agent that referenced this pull request Aug 26, 2026
- Add api.fireworks.ai to _URL_TO_PROVIDER for automatic provider detection
- Add fireworks to PROVIDER_TO_MODELS_DEV mapped to 'fireworks-ai' (the
  correct models.dev provider key — original PR used 'fireworks' which
  would silently fail the lookup)

Co-authored-by: sroecker <sroecker@users.noreply.github.com>
Cherry-picked from PR NousResearch#3989 with models.dev key fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants