Skip to content

fix(lazy-deps): set CMAKE_POLICY_VERSION_MINIMUM=3.5 for native builds #39816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MwC-Trexx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lazy-deps): set CMAKE_POLICY_VERSION_MINIMUM=3.5 for native builds #39816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/lazy_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,10 @@ def _venv_pip_install(specs: tuple[str, ...], *, timeout: int = 300) -> _Install
return _InstallResult(True, "", "")

venv_root = Path(sys.executable).parent.parent
uv_env = {**os.environ, "VIRTUAL_ENV": str(venv_root)}
# cmake 4.x removed compatibility with cmake_minimum_required < 3.5.

@teknium1 teknium1 Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please carry this explicit environment into the python -m pip install fallback as well. Current main's fallback runs without env= at tools/lazy_deps.py:702, so an unavailable or failed uv binary would still invoke CMake without this policy setting.

# python-olm (mautrix[encryption]) bundles libolm/CMakeLists.txt that
# declares VERSION 3.4; this env var lets cmake 4.x configure it anyway.
uv_env = {**os.environ, "VIRTUAL_ENV": str(venv_root), "CMAKE_POLICY_VERSION_MINIMUM": "3.5"}

# Tier 1: uv (preferred — fast, doesn't need pip in the venv)
uv_bin = shutil.which("uv")
Expand Down