fix(gateway): refresh QQBot sessions before timeout - #39583
Closed
weathour wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes QQBot gateway session refresh so long-running sessions proactively reconnect/resume before the QQ gateway closes them with
4009 Session timed out.The adapter now:
READY;RESUMED;QQCloseErrorso the existing reconnect/resume path runs instead of silently returning.Related Issue
No issue number.
Related PRs checked to avoid duplication:
mainalready preserves 4009 as resumable; this PR adds proactive refresh after READY/RESUMED.Type of Change
Changes Made
gateway/platforms/qqbot/adapter.pySESSION_REFRESH_SECONDSand_session_refresh_tasklifecycle.READY/RESUMED.QQCloseErrorfor reconnect handling.tests/gateway/test_qqbot.pyNonewebsocket no-op behavior.How to Test
scripts/run_tests.sh tests/gateway/test_qqbot.pyvenv/bin/python scripts/check-windows-footguns.py --diff origin/maingit diff --check origin/main..HEADAll passed locally after rebasing onto latest
origin/main.Checklist
Code
Documentation & Housekeeping
cli-config.yaml.example— N/A, no config keys added.CONTRIBUTING.mdorAGENTS.md— N/A, no workflow/architecture docs changed.Screenshots / Logs
Validation: