Skip to content

[codex] fix(tests): stabilize local interrupt cleanup check #39496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sweetcornna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[codex] fix(tests): stabilize local interrupt cleanup check #39496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/tools/test_local_interrupt_cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
from tools.environments import local as local_mod
from tools.environments.local import LocalEnvironment

requires_posix_process_groups = pytest.mark.skipif(
not hasattr(os, "getpgid") or not hasattr(os, "killpg"),
reason="POSIX process-group cleanup semantics",
)


@pytest.fixture(autouse=True)
def _isolate_hermes_home(tmp_path, monkeypatch):
Expand All @@ -33,7 +38,7 @@ def _isolate_hermes_home(tmp_path, monkeypatch):
def _pgid_still_alive(pgid: int) -> bool:
"""Return True if any process in the given process group is still alive."""
try:
os.killpg(pgid, 0) # signal 0 = existence check
os.killpg(pgid, 0) # signal 0 = existence check # windows-footgun: ok
return True
except ProcessLookupError:
return False
Expand Down Expand Up @@ -65,6 +70,7 @@ def _wait_for_pgid_exit(pgid: int, timeout: float = 60.0) -> bool:
return not _pgid_still_alive(pgid)


@requires_posix_process_groups
def test_kill_process_uses_cached_pgid_if_wrapper_already_exited(monkeypatch):
"""If the shell wrapper exits before cleanup, still kill its process group.

Expand Down Expand Up @@ -97,6 +103,7 @@ def fake_killpg(pgid, sig):
assert killpg_calls == [(67890, signal.SIGTERM), (67890, 0)]


@requires_posix_process_groups
def test_wait_for_process_kills_subprocess_on_keyboardinterrupt():
"""When KeyboardInterrupt arrives mid-poll, the subprocess group must be
killed before the exception is re-raised."""
Expand Down
Loading