Skip to content

fix(update): pause Windows gateway before venv refresh - #39487

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/39431-windows-update-gateway
Closed

fix(update): pause Windows gateway before venv refresh#39487
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/39431-windows-update-gateway

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • stop an installed Windows gateway service before the dependency refresh step in hermes update
  • reuse the existing post-update gateway recovery path to resume the gateway after the update finishes
  • add focused tests for pause/resume helpers and the update flow hook

Fixes #39431.

Verification

  • `pytest -q -o addopts= tests/hermes_cli/test_update_concurrent_quarantine.py -k pause_windows_gateway

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery labels Jun 5, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Windows update fix. Current main already contains a broader implementation. This is an automated hermes-sweeper review.

  • Commit 78c11d99e35b111dd6198d8bc6aa1f7f6f168232 (fix(update): stop Windows gateways before mutating install) shipped in v2026.6.19.
  • hermes_cli/main.py:90299157 discovers all Windows gateway PIDs, gracefully pauses mapped profile gateways, and handles unmapped gateway processes before update mutation.
  • hermes_cli/main.py:9490 invokes that pause before venv lock checks and update work; hermes_cli/main.py:92059268 and :11006 restore paused gateways.
  • tests/hermes_cli/test_update_concurrent_quarantine.py:456710 covers mapped/unmapped pause-resume paths and installed-gateway cold starts.
  • The linked follow-up fix(update): stop Windows gateways before mutating install #45457 specifically addressed the Desktop --gateway --force gap in this PR's gateway_mode guard; current main covers that broader case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Auto-update fails on Windows — speedups.pyd access denied (venv bootstrap)

3 participants