Improve Discord exec approval summaries - #39440
Closed
ryouchida715 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing as superseded: #60245 restructured send_exec_approval so the full command (up to ~1900 chars) is now visible in plain message content next to the buttons, which addresses the readability problem this PR targeted. The head/tail elision idea was a nice touch but conflicts with the new layout. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
In Discord, dangerous command approval prompts currently show the raw command and "Reason" first. For non-engineer users this makes it unclear what action is being requested. This change keeps the command visible, but puts a short actionable explanation first.
Test Plan
python -m pytest tests/gateway/test_discord_exec_approval_summary.py -q -o 'addopts='→ 3 passedpython -m py_compile plugins/platforms/discord/adapter.py tests/gateway/test_discord_exec_approval_summary.py→ exit 0git diff HEAD --check→ exit 0Notes