feat(installer): do shallow clones - #39423
Merged
Merged
Conversation
no need to get the whole repo history :)
Contributor
🔎 Lint report:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The installer scripts (
install.shandinstall.ps1) currently do full clones of the hermes-agent repo, pulling the entire history. For a one-shot install that just needs the latest files on a given branch, this is unnecessary — it wastes bandwidth and makes the clone noticeably slower on large repos.This PR adds
--depth 1to all fourgit cloneinvocations (SSH + HTTPS in both scripts) so the installer only fetches the tip of the branch. This is safe because:git pullinside the install dir will still work (Git auto-expands the shallow boundary on pull).Related Issue
Fixes #
Type of Change
Changes Made
scripts/install.sh: Added--depth 1to both SSH and HTTPSgit clonecommandsscripts/install.ps1: Added--depth 1to both SSH and HTTPSgit clonecommandsHow to Test
scripts/install.shon a Linux/macOS machine — verify it clones successfully and the installed dir has the expected filesscripts/install.ps1on a Windows machine — verify same.gitdirectory is shallow:git -C <install-dir> rev-list --count HEADshould return1Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — no visual changes.
Infographic