fix(desktop): sync model header when switching cached sessions - #39361
Closed
Tamaz-sujashvili wants to merge 1 commit into
Closed
fix(desktop): sync model header when switching cached sessions#39361Tamaz-sujashvili wants to merge 1 commit into
Tamaz-sujashvili wants to merge 1 commit into
Conversation
The fast resume path updated cwd/branch but not model/provider, so the header stayed on the previous session's model until a full gateway resume. Fixes NousResearch#38901 Co-authored-by: Cursor <cursoragent@cursor.com>
|
I hit this while auditing the Desktop model menu/status UX. Two related details seem important beyond just refreshing the header label:
I opened #40163 with a narrow patch for those pieces plus one UI cleanup: inactive model rows no longer show This should complement the direction here rather than change the intent of this PR. |
Contributor
|
Thanks for the focused Desktop report and patch. This is now covered by a more complete implementation on current Automated hermes-sweeper review verified:
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast resume path now applies stored model and refreshes
model.optionsso the picker matches the active session.Test plan
Fixes #38901
Made with Cursor