Skip to content

fix: share Codex credential pool across profiles - #39352

Closed
klvnkeegen wants to merge 1 commit into
NousResearch:mainfrom
klvnkeegen:fix/codex-shared-root-pool
Closed

fix: share Codex credential pool across profiles#39352
klvnkeegen wants to merge 1 commit into
NousResearch:mainfrom
klvnkeegen:fix/codex-shared-root-pool

Conversation

@klvnkeegen

@klvnkeegen klvnkeegen commented Jun 4, 2026

Copy link
Copy Markdown

Summary

  • Treat openai-codex as a shared credential-pool provider in profile mode.
  • Prefer the root/default Codex pool over stale profile-local Codex entries when reading provider slices or whole-pool data.
  • Route write_credential_pool("openai-codex", ...) to the root/default auth store in profile mode, with a path-specific lock, so refresh/exhaustion updates do not fork profile-local OAuth state.
  • Preserve existing per-profile shadowing semantics for non-Codex providers.

Test Plan

  • PYTHONDONTWRITEBYTECODE=1 python3 -m pytest tests/hermes_cli/test_auth_profile_fallback.py tests/agent/test_credential_pool.py -q -o 'addopts=' -p no:cacheprovider
  • PYTHONDONTWRITEBYTECODE=1 python3 -m pytest tests/hermes_cli/test_auth*.py tests/agent/test_credential_pool.py -q -o 'addopts=' -p no:cacheprovider

Local deployment verification

  • Backported the same patch into the running Docker image-layer /opt/hermes using root-in-container via the Docker socket because /opt/hermes is root-owned.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard area/auth Authentication, OAuth, credential pools provider/openai OpenAI / Codex Responses API codex labels Jun 4, 2026
@klvnkeegen

Copy link
Copy Markdown
Author

Closing after sustained monitoring with no upstream movement. This PR now conflicts with current main and the local deployment path has been handled separately; keeping the stale watcher/PR open is no longer useful. Happy to reopen or port the Codex shared-pool behavior if maintainers want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools codex comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/openai OpenAI / Codex Responses API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants