fix: share Codex credential pool across profiles - #39352
Closed
klvnkeegen wants to merge 1 commit into
Closed
Conversation
Author
|
Closing after sustained monitoring with no upstream movement. This PR now conflicts with current main and the local deployment path has been handled separately; keeping the stale watcher/PR open is no longer useful. Happy to reopen or port the Codex shared-pool behavior if maintainers want it. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-codexas a shared credential-pool provider in profile mode.write_credential_pool("openai-codex", ...)to the root/default auth store in profile mode, with a path-specific lock, so refresh/exhaustion updates do not fork profile-local OAuth state.Test Plan
PYTHONDONTWRITEBYTECODE=1 python3 -m pytest tests/hermes_cli/test_auth_profile_fallback.py tests/agent/test_credential_pool.py -q -o 'addopts=' -p no:cacheproviderPYTHONDONTWRITEBYTECODE=1 python3 -m pytest tests/hermes_cli/test_auth*.py tests/agent/test_credential_pool.py -q -o 'addopts=' -p no:cacheproviderLocal deployment verification
/opt/hermesusing root-in-container via the Docker socket because/opt/hermesis root-owned.