fix(desktop): clear stale session bubbles and busy state on new chat - #39211
Open
Morad37 wants to merge 1 commit into
Open
fix(desktop): clear stale session bubbles and busy state on new chat#39211Morad37 wants to merge 1 commit into
Morad37 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for isolating the new-chat/session-state interaction. The transcript-bleed portion is already guarded on current main, but the proposed status handling conflicts with the current background-session model. Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #37975, a newly-started chat could visually show stale user bubbles and red session busy errors from another live session. This was render contamination, not model-context contamination — the assistant in the new chat ignored the stale visuals.
Two changes:
Fixes #39086