Skip to content

fix(desktop): unpack dist/** so Python backend can serve the web bundle #39093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foras910521-lab wants to merge 1 commit into from
Closed

fix(desktop): unpack dist/** so Python backend can serve the web bundle #39093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@
"asar": true,
"afterSign": "scripts/notarize.cjs",
"asarUnpack": [
"dist/**",
"**/*.node",
"**/prebuilds/**"
],
Expand Down
19 changes: 19 additions & 0 deletions tests/test_desktop_packaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
"""Regression guards for the packaged Hermes Desktop bundle config."""

from __future__ import annotations

import json
from pathlib import Path


REPO_ROOT = Path(__file__).resolve().parents[1]


def test_desktop_dist_is_unpacked_for_python_backend():
package_json = json.loads(
(REPO_ROOT / "apps" / "desktop" / "package.json").read_text(encoding="utf-8")
)

asar_unpack = package_json.get("build", {}).get("asarUnpack", [])

assert "dist/**" in asar_unpack