fix: use thread-based timeouts for cross-platform compatibility - #38870
Closed
mohamedswe wants to merge 0 commit into
Closed
fix: use thread-based timeouts for cross-platform compatibility#38870mohamedswe wants to merge 0 commit into
mohamedswe wants to merge 0 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Windows pytest compatibility by switching from signal-based to thread-based timeouts. The signal method uses
SIGALRMwhich is POSIX-only and causesAttributeErroron Windows. Thread method works cross-platform with negligible performance difference.Root cause:
tests/conftest.pyline 448 mentions "The old SIGALRM-based fixture (POSIX-only, didn't work on Windows) is gone" butpyproject.tomlstill referenced signal method.Related Issue
No existing issue - discovered during Windows contributor environment setup.
Type of Change
Changes Made
pytest-timeoutmethod fromsignaltothreadinpyproject.tomlline 287How to Test
Before (main branch, Windows):
After (this branch, Windows):
Checklist
Code
fix:)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.example— N/ACONTRIBUTING.mdorAGENTS.md— N/AScreenshots / Logs
Before fix (main branch, Windows 11, Python 3.11.9):
After fix (fix/windows-pytest-timeout branch, Windows 11, Python 3.11.9):
Key difference:
timeout method: signal→timeout method: thread✅